Keep focus on Find-In-Page buttons when using the keyboard to navigate.

chrome/browser/ui/views/find_bar_views_interactive_uitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/macros.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/ui/browser.h"
@@ skipping 90 matching lines @@
   ui_test_utils::NavigateToURL(browser(),
                                embedded_test_server()->GetURL(kSimplePage));
   // Show the Find bar.
   browser()->GetFindBarController()->Show();
   EXPECT_TRUE(
       ui_test_utils::IsViewFocused(browser(), VIEW_ID_FIND_IN_PAGE_TEXT_FIELD));
   ui_test_utils::FindInPage(
       browser()->tab_strip_model()->GetActiveWebContents(), ASCIIToUTF16("a"),
       true, false, NULL, NULL);
 
-  // The textfield should be focused after pressing [Enter] on the find button.
+  // The previous button should still be focused after pressing [Enter] on it.
   ASSERT_TRUE(ui_test_utils::SendKeyPressSync(browser(), ui::VKEY_TAB, false,
                                               false, false, false));
   ASSERT_TRUE(ui_test_utils::SendKeyPressSync(browser(), ui::VKEY_RETURN, false,
                                               false, false, false));
   EXPECT_TRUE(
-      ui_test_utils::IsViewFocused(browser(), VIEW_ID_FIND_IN_PAGE_TEXT_FIELD));
+      ui_test_utils::IsViewFocused(browser(),
+      VIEW_ID_FIND_IN_PAGE_PREVIOUS_BUTTON));
 
-  // The textfield should be focused after pressing [Enter] on the find button.
+  // The next button should still be focused after pressing [Enter] on it.
   ui_test_utils::FindInPage(
       browser()->tab_strip_model()->GetActiveWebContents(), ASCIIToUTF16("b"),
       true, false, NULL, NULL);
   ASSERT_TRUE(ui_test_utils::SendKeyPressSync(browser(), ui::VKEY_TAB, false,
                                               false, false, false));
-  ASSERT_TRUE(ui_test_utils::SendKeyPressSync(browser(), ui::VKEY_TAB, false,
-                                              false, false, false));
   ASSERT_TRUE(ui_test_utils::SendKeyPressSync(browser(), ui::VKEY_RETURN, false,
                                               false, false, false));
   EXPECT_TRUE(
+      ui_test_utils::IsViewFocused(browser(),
+      VIEW_ID_FIND_IN_PAGE_NEXT_BUTTON));
+}
+
+// TODO(mpistrich): Enable again when ui_test_utils::ClickOnView works with find

[msw, 2016/02/03 19:58:02]

Why doesn't ClickOnView work with these buttons?

[Mario Pistrich, 2016/02/03 20:41:59]

I couldn't figure it out why ClickOnView does not work with these buttons. It
doesn't work with VIEW_ID_FIND_IN_PAGE_TEXT_FIELD either.
BrowserView::GetViewByID returned a nullptr. It seems like the view of the find
bar is contained in the BrowserView.

Should I try to fix this issue in this CL? Alternatively I can open another
issue and link to this test case.

[msw, 2016/02/03 21:43:34]

Please file a bug and cite in this comment; follow up afterwards.

[Mario Pistrich, 2016/02/03 23:32:54]

Done, see http://crbug.com/584043

+// bar view IDs.
+IN_PROC_BROWSER_TEST_F(FindInPageTest, DISABLED_NavigationByMouse) {
+  ASSERT_TRUE(embedded_test_server()->Start());
+  // Make sure Chrome is in the foreground, otherwise sending input
+  // won't do anything and the test will hang.
+  ASSERT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));
+  // First we navigate to any page.
+  ui_test_utils::NavigateToURL(browser(),
+                               embedded_test_server()->GetURL(kSimplePage));
+  // Show the Find bar.
+  browser()->GetFindBarController()->Show();
+  EXPECT_TRUE(
       ui_test_utils::IsViewFocused(browser(), VIEW_ID_FIND_IN_PAGE_TEXT_FIELD));
+  ui_test_utils::FindInPage(
+      browser()->tab_strip_model()->GetActiveWebContents(), ASCIIToUTF16("a"),
+      true, false, NULL, NULL);
+
+  // The textfield should be focused after clicking on any button.
+  ui_test_utils::ClickOnView(browser(), VIEW_ID_FIND_IN_PAGE_PREVIOUS_BUTTON);
+  EXPECT_TRUE(
+      ui_test_utils::IsViewFocused(browser(),
+      VIEW_ID_FIND_IN_PAGE_PREVIOUS_BUTTON));

[msw, 2016/02/03 19:58:02]

This should be VIEW_ID_FIND_IN_PAGE_TEXT_FIELD

[Mario Pistrich, 2016/02/03 20:41:59]

Done.

+
+  // The textfield should be focused after clicking on any button.
+  ui_test_utils::ClickOnView(browser(), VIEW_ID_FIND_IN_PAGE_NEXT_BUTTON);
+  EXPECT_TRUE(
+      ui_test_utils::IsViewFocused(browser(),
+      VIEW_ID_FIND_IN_PAGE_NEXT_BUTTON));

[msw, 2016/02/03 19:58:02]

Ditto: This should be VIEW_ID_FIND_IN_PAGE_TEXT_FIELD

[Mario Pistrich, 2016/02/03 20:41:59]

Done.

 }
 
 #if defined(OS_LINUX) && !defined(OS_CHROMEOS) && defined(USE_AURA)
 // TODO(erg): linux_aura bringup: http://crbug.com/163931
 #define MAYBE_FocusRestore DISABLED_FocusRestore
 #else
 #define MAYBE_FocusRestore FocusRestore
 #endif
 
 // Flaky because the test server fails to start? See: http://crbug.com/96594.
@@ skipping 334 matching lines @@
   ui_test_utils::UrlLoadObserver observer(
       GURL("about:blank"), content::NotificationService::AllSources());
 
   // Send Ctrl-Enter, should cause navigation to about:blank.
   ASSERT_TRUE(ui_test_utils::SendKeyPressSync(
       browser(), ui::VKEY_RETURN, true, false, false, false));
 
   observer.Wait();
 }
 #endif