Revert of [api] Make ObjectTemplate::SetNativeDataProperty() work even if the ObjectTemplate ...

Revert of [api] Make ObjectTemplate::SetNativeDataProperty() work even if the ObjectTemplate does not have a … (patchset #3 id:80001 of https://codereview.chromium.org/1642223003/ )

Reason for revert:
Fails a lot of layout tests and blocks the roll. Can be easily reproduced with a local Chromium checkout.

Reference: https://codereview.chromium.org/1652413003/

Original issue's description:
> [api] Make ObjectTemplate::SetNativeDataProperty() work even if the ObjectTemplate does not have a constructor.
>
> Previously ObjectTemplate::New() logic relied on the fact that all the accessor properties are already installed in the initial map of the function object of the constructor FunctionTemplate.
> When the FunctionTemplate were instantiated the accessors of the instance templates from the whole inheritance chain were accumulated and added to the initial map.
> ObjectTemplate::SetSetAccessor() used to explicitly ensure that the ObjectTemplate has a constructor and therefore an initial map to add all accessors to.
>
> The new approach is to add all the accessors and data properties to the object exactly when the ObjectTemplate is instantiated. In order to keep it fast we now cache the object boilerplates in the Isolate::template_instantiations_cache (the former function_cache), so the object creation turns to be a deep copying of the boilerplate object.
>
> This CL also prohibits non-primitive properties in ObjectTemplate to avoid potential cross-context leaks.
>
> BUG=chromium:579009
> LOG=Y
>
> Committed: https://crrev.com/6a118774244d087b5979e9291d628a994f21d59d
> Cr-Commit-Position: refs/heads/master@{#33674}

TBR=verwaest@chromium.org,ishell@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:579009
Committed: https://crrev.com/db47a31fb9ceefb260a415e4882822a852084221
Cr-Commit-Position: refs/heads/master@{#33698}

[Michael Hablich, 2016-02-03 09:52:16]

Created Revert of [api] Make ObjectTemplate::SetNativeDataProperty() work even
if the ObjectTemplate does not have a …

[commit-bot: I haz the power, 2016-02-03 09:52:49]

Description was changed from

==========
Revert of [api] Make ObjectTemplate::SetNativeDataProperty() work even if the
ObjectTemplate does not have a … (patchset #3 id:80001 of
https://codereview.chromium.org/1642223003/ )

Reason for revert:
Fails a lot of layout tests and blocks the roll. Can be easily reproduced with a
local Chromium checkout.

Reference: https://codereview.chromium.org/1652413003/

Original issue's description:
> [api] Make ObjectTemplate::SetNativeDataProperty() work even if the
ObjectTemplate does not have a constructor.
> 
> Previously ObjectTemplate::New() logic relied on the fact that all the
accessor properties are already installed in the initial map of the function
object of the constructor FunctionTemplate.
> When the FunctionTemplate were instantiated the accessors of the instance
templates from the whole inheritance chain were accumulated and added to the
initial map.
> ObjectTemplate::SetSetAccessor() used to explicitly ensure that the
ObjectTemplate has a constructor and therefore an initial map to add all
accessors to.
> 
> The new approach is to add all the accessors and data properties to the object
exactly when the ObjectTemplate is instantiated. In order to keep it fast we now
cache the object boilerplates in the Isolate::template_instantiations_cache (the
former function_cache), so the object creation turns to be a deep copying of the
boilerplate object.
> 
> This CL also prohibits non-primitive properties in ObjectTemplate to avoid
potential cross-context leaks.
> 
> BUG=chromium:579009
> LOG=Y
> 
> Committed: https://crrev.com/6a118774244d087b5979e9291d628a994f21d59d
> Cr-Commit-Position: refs/heads/master@{#33674}

TBR=verwaest@chromium.org,ishell@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:579009
==========

to

==========
Revert of [api] Make ObjectTemplate::SetNativeDataProperty() work even if the
ObjectTemplate does not have a … (patchset #3 id:80001 of
https://codereview.chromium.org/1642223003/ )

Reason for revert:
Fails a lot of layout tests and blocks the roll. Can be easily reproduced with a
local Chromium checkout.

Reference: https://codereview.chromium.org/1652413003/

Original issue's description:
> [api] Make ObjectTemplate::SetNativeDataProperty() work even if the
ObjectTemplate does not have a constructor.
> 
> Previously ObjectTemplate::New() logic relied on the fact that all the
accessor properties are already installed in the initial map of the function
object of the constructor FunctionTemplate.
> When the FunctionTemplate were instantiated the accessors of the instance
templates from the whole inheritance chain were accumulated and added to the
initial map.
> ObjectTemplate::SetSetAccessor() used to explicitly ensure that the
ObjectTemplate has a constructor and therefore an initial map to add all
accessors to.
> 
> The new approach is to add all the accessors and data properties to the object
exactly when the ObjectTemplate is instantiated. In order to keep it fast we now
cache the object boilerplates in the Isolate::template_instantiations_cache (the
former function_cache), so the object creation turns to be a deep copying of the
boilerplate object.
> 
> This CL also prohibits non-primitive properties in ObjectTemplate to avoid
potential cross-context leaks.
> 
> BUG=chromium:579009
> LOG=Y
> 
> Committed: https://crrev.com/6a118774244d087b5979e9291d628a994f21d59d
> Cr-Commit-Position: refs/heads/master@{#33674}

TBR=verwaest@chromium.org,ishell@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:579009
==========

[commit-bot: I haz the power, 2016-02-03 09:53:29]

Description was changed from

==========
Revert of [api] Make ObjectTemplate::SetNativeDataProperty() work even if the
ObjectTemplate does not have a … (patchset #3 id:80001 of
https://codereview.chromium.org/1642223003/ )

Reason for revert:
Fails a lot of layout tests and blocks the roll. Can be easily reproduced with a
local Chromium checkout.

Reference: https://codereview.chromium.org/1652413003/

Original issue's description:
> [api] Make ObjectTemplate::SetNativeDataProperty() work even if the
ObjectTemplate does not have a constructor.
> 
> Previously ObjectTemplate::New() logic relied on the fact that all the
accessor properties are already installed in the initial map of the function
object of the constructor FunctionTemplate.
> When the FunctionTemplate were instantiated the accessors of the instance
templates from the whole inheritance chain were accumulated and added to the
initial map.
> ObjectTemplate::SetSetAccessor() used to explicitly ensure that the
ObjectTemplate has a constructor and therefore an initial map to add all
accessors to.
> 
> The new approach is to add all the accessors and data properties to the object
exactly when the ObjectTemplate is instantiated. In order to keep it fast we now
cache the object boilerplates in the Isolate::template_instantiations_cache (the
former function_cache), so the object creation turns to be a deep copying of the
boilerplate object.
> 
> This CL also prohibits non-primitive properties in ObjectTemplate to avoid
potential cross-context leaks.
> 
> BUG=chromium:579009
> LOG=Y
> 
> Committed: https://crrev.com/6a118774244d087b5979e9291d628a994f21d59d
> Cr-Commit-Position: refs/heads/master@{#33674}

TBR=verwaest@chromium.org,ishell@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:579009
==========

to

==========
Revert of [api] Make ObjectTemplate::SetNativeDataProperty() work even if the
ObjectTemplate does not have a … (patchset #3 id:80001 of
https://codereview.chromium.org/1642223003/ )

Reason for revert:
Fails a lot of layout tests and blocks the roll. Can be easily reproduced with a
local Chromium checkout.

Reference: https://codereview.chromium.org/1652413003/

Original issue's description:
> [api] Make ObjectTemplate::SetNativeDataProperty() work even if the
ObjectTemplate does not have a constructor.
>
> Previously ObjectTemplate::New() logic relied on the fact that all the
accessor properties are already installed in the initial map of the function
object of the constructor FunctionTemplate.
> When the FunctionTemplate were instantiated the accessors of the instance
templates from the whole inheritance chain were accumulated and added to the
initial map.
> ObjectTemplate::SetSetAccessor() used to explicitly ensure that the
ObjectTemplate has a constructor and therefore an initial map to add all
accessors to.
>
> The new approach is to add all the accessors and data properties to the object
exactly when the ObjectTemplate is instantiated. In order to keep it fast we now
cache the object boilerplates in the Isolate::template_instantiations_cache (the
former function_cache), so the object creation turns to be a deep copying of the
boilerplate object.
>
> This CL also prohibits non-primitive properties in ObjectTemplate to avoid
potential cross-context leaks.
>
> BUG=chromium:579009
> LOG=Y
>
> Committed: https://crrev.com/6a118774244d087b5979e9291d628a994f21d59d
> Cr-Commit-Position: refs/heads/master@{#33674}

TBR=verwaest@chromium.org,ishell@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:579009

Committed: https://crrev.com/db47a31fb9ceefb260a415e4882822a852084221
Cr-Commit-Position: refs/heads/master@{#33698}
==========

[Michael Achenbach, 2016-02-03 10:01:14]

On 2016/02/03 09:52:16, Hablich wrote:
> Created Revert of [api] Make ObjectTemplate::SetNativeDataProperty() work even
> if the ObjectTemplate does not have a …

Could you point me to a failing layout test? I don't see any on our bots. And as
far as I remember, the layout tests don't even run on deps changes on the CQ.

[Michael Hablich, 2016-02-03 10:03:31]

On 2016/02/03 10:01:14, Michael Achenbach wrote:
> On 2016/02/03 09:52:16, Hablich wrote:
> > Created Revert of [api] Make ObjectTemplate::SetNativeDataProperty() work
even
> > if the ObjectTemplate does not have a …
> 
> Could you point me to a failing layout test? I don't see any on our bots. And
as
> far as I remember, the layout tests don't even run on deps changes on the CQ.

I bisected with out/Release/interactive_ui_tests
--gtest_filter=WebViewInteractiveTest.Focus_AdvanceFocus. Taken from the log in
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium....

So it is a non-layout test.