Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1660253002: Make sure we have a root content layer before setting children. (Closed)

Created:
4 years, 10 months ago by wkorman
Modified:
4 years, 10 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make sure we have a root content layer before setting children. BUG=556382 Committed: https://crrev.com/9e815b78b7f1576d2030ba76b1f9c7eb5eb49068 Cr-Commit-Position: refs/heads/master@{#373140}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
wkorman
I don't think we need to call ensureRootLayer() because it is called indirectly, if appropriate, ...
4 years, 10 months ago (2016-02-03 01:20:50 UTC) #2
chrishtr
lgtm
4 years, 10 months ago (2016-02-03 01:21:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1660253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1660253002/1
4 years, 10 months ago (2016-02-03 01:24:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-03 02:50:41 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 02:51:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e815b78b7f1576d2030ba76b1f9c7eb5eb49068
Cr-Commit-Position: refs/heads/master@{#373140}

Powered by Google App Engine
This is Rietveld 408576698