Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1660213002: GN: Don't write ldflags and libs when unneeded. (Closed)

Created:
4 years, 10 months ago by brettw
Modified:
4 years, 10 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Don't write ldflags and libs when unneeded. Previously ldflags and libs were emitted for every linked target including static libraries. These variables are documented to not apply to static libraries and are unneeded in that case. Improve the documentation for "libs". BUG=570015 Committed: https://crrev.com/b2c920d22ae5721ce4a32a8dc524d13b08356593 Cr-Commit-Position: refs/heads/master@{#373111}

Patch Set 1 #

Patch Set 2 : Update reference #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -50 lines) Patch
M tools/gn/docs/reference.md View 1 14 chunks +111 lines, -25 lines 0 comments Download
M tools/gn/ninja_binary_target_writer.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M tools/gn/ninja_binary_target_writer_unittest.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M tools/gn/variables.cc View 2 chunks +29 lines, -17 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
brettw
4 years, 10 months ago (2016-02-02 23:46:56 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1660213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1660213002/1
4 years, 10 months ago (2016-02-02 23:52:43 UTC) #4
Dirk Pranke
lgtm, but can you update //tools/gn/docs/reference.md as well?
4 years, 10 months ago (2016-02-02 23:55:31 UTC) #6
brettw
On 2016/02/02 23:55:31, Dirk Pranke wrote: > lgtm, but can you update //tools/gn/docs/reference.md as well? ...
4 years, 10 months ago (2016-02-03 00:23:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1660213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1660213002/20001
4 years, 10 months ago (2016-02-03 00:26:34 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-03 01:18:34 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 01:19:54 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b2c920d22ae5721ce4a32a8dc524d13b08356593
Cr-Commit-Position: refs/heads/master@{#373111}

Powered by Google App Engine
This is Rietveld 408576698