Issue 1660203002: VM: Fix bug with break out of a try-finally inside a loop.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1660203002: VM: Fix bug with break out of a try-finally inside a loop. (Closed)

Created:
4 years, 10 months ago by Florian Schneider

Modified:
4 years, 10 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

VM: Fix bug with break out of a try-finally inside a loop. The break-target block was assigned the wrong try-index. BUG=dartbug.com/25654 R=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/b354660f026c607710d2889d5b427dcbc9d84cf7

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -3 lines)			Patch
	M	runtime/vm/flow_graph_builder.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
	A	tests/language/try_finally_regress_25654_test.dart	View		1 chunk	+36 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Florian Schneider

4 years, 10 months ago (2016-02-03 01:09:12 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b354660f026c607710d2889d5b427dcbc9d84cf7 (presubmit successful).