content/renderer/render_view_impl.cc - Issue 1660193007: [Presentation API] Adding a flag to disable gesture check for starting presentations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.cc

Issue 1660193007: [Presentation API] Adding a flag to disable gesture check for starting presentations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressing avayvod@'s comments and several fixes Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/common/web_preferences.cc ('k') | third_party/WebKit/Source/core/frame/Settings.in » ('j') | third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_view_impl.cc

diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc

index 36d226cd2a3b669b57d0993618ab36e6bd50129d..63951caca3601f7683428442cf6a2404018b219c 100644

--- a/content/renderer/render_view_impl.cc

+++ b/content/renderer/render_view_impl.cc

@@ -1064,6 +1064,9 @@ void RenderView::ApplyWebPreferences(const WebPreferences& prefs,

settings->setImageAnimationPolicy(

static_cast<WebSettings::ImageAnimationPolicy>(prefs.animation_policy));

+ settings->setPresentationRequiresUserGesture(

+ prefs.user_gesture_required_for_presentation);

// Needs to happen before setIgnoreVIewportTagScaleLimits below.

web_view->setDefaultPageScaleLimits(

prefs.default_minimum_page_scale_factor,