Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1660163002: Roll recipe dependencies (nontrivial). (Closed)

Created:
4 years, 10 months ago by recipe-roller
Modified:
4 years, 10 months ago
Reviewers:
luqui, martiniss
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools@base
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Roll recipe dependencies (nontrivial). recipe_engine -> 44b384f9b4f1085e9cfe43ea6308735a3af8d4e5: RELAND of Make the recipe engine allow modules named the same thing to co-exist. R=martiniss@chromium.org,luqui@chromium.org TBR=iannucci@chromium.org BUG=582280 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298530

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -35 lines) Patch
M infra/config/recipes.cfg View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/basic.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/basic_output_manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/basic_with_branch_heads.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/clobber.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/forced.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/no_shallow.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/off.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/reset_root_solution_revision.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/svn_mode.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/trychange.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/trychange_oauth2.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_fail.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_fail_patch.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_fail_patch_download.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_v8.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/git/example.expected/basic.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/git/example.expected/basic_branch.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/git/example.expected/basic_file_name.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/git/example.expected/basic_hash.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/git/example.expected/basic_ref.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/git/example.expected/basic_submodule_update_force.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/git/example.expected/can_fail_build.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/git/example.expected/cannot_fail_build.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/git/example.expected/cat-file_test.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/git/example.expected/count-objects_delta.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/git/example.expected/count-objects_failed.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/git/example.expected/count-objects_with_bad_output.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/git/example.expected/count-objects_with_bad_output_fails_build.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/git/example.expected/curl_trace_file.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/git/example.expected/platform_win.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/git/example.expected/rebase_failed.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/git/example.expected/remote_not_origin.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/git/example.expected/set_got_revision.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
recipe-roller
4 years, 10 months ago (2016-02-02 22:40:11 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1660163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1660163002/1
4 years, 10 months ago (2016-02-02 22:40:17 UTC) #3
luqui
lgtm
4 years, 10 months ago (2016-02-02 22:40:54 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-02 22:43:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1660163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1660163002/1
4 years, 10 months ago (2016-02-02 22:44:00 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: depot_tools_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/depot_tools_presubmit/builds/402)
4 years, 10 months ago (2016-02-02 22:48:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1660163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1660163002/1
4 years, 10 months ago (2016-02-02 22:48:50 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 22:51:54 UTC) #15
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298530

Powered by Google App Engine
This is Rietveld 408576698