Add SharedMemory version of PersistentMemoryAllocator.

base/metrics/persistent_memory_allocator.h

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_METRICS_PERSISTENT_MEMORY_ALLOCATOR_H_
 #define BASE_METRICS_PERSISTENT_MEMORY_ALLOCATOR_H_
 
 #include <stdint.h>
 #include <atomic>
 #include <string>
 
 #include "base/atomicops.h"
 #include "base/base_export.h"
 #include "base/gtest_prod_util.h"
 #include "base/macros.h"
 #include "base/memory/scoped_ptr.h"
 
 namespace base {
 
 class HistogramBase;
 class MemoryMappedFile;
+class SharedMemory;
 
 // Simple allocator for pieces of a memory block that may be persistent
 // to some storage or shared across multiple processes. This class resides
 // under base/metrics because it was written for that purpose. It is,
 // however, fully general-purpose and can be freely moved to base/memory
 // if other uses are found.
 //
 // This class provides for thread-secure (i.e. safe against other threads
 // or processes that may be compromised and thus have malicious intent)
 // allocation of memory within a designated block and also a mechanism by
@@ skipping 269 matching lines @@
  public:
   LocalPersistentMemoryAllocator(size_t size, uint64_t id,
                                  const std::string& name);
   ~LocalPersistentMemoryAllocator() override;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(LocalPersistentMemoryAllocator);
 };
 
 
+// This allocator takes a shared-memory object and performs allocation from
+// it. The memory must be previously mapped via Map() or MapAt(). The allocator
+// takes ownership of the memory object.
+class BASE_EXPORT SharedPersistentMemoryAllocator
+    : public PersistentMemoryAllocator {
+ public:
+  SharedPersistentMemoryAllocator(scoped_ptr<SharedMemory> mem, uint64_t id,

[Alexei Svitkine (slow), 2016/02/05 21:54:02]

Nit: 1 param per line.

|mem| -> |memory|

[bcwhite, 2016/02/06 04:26:11]

Done.

+                                  const std::string& name, bool read_only);
+  ~SharedPersistentMemoryAllocator() override;
+
+  SharedMemory* GetSharedMemory() { return shared_memory_.get(); }

[Alexei Svitkine (slow), 2016/02/05 21:54:02]

Nit: Either a method is trivial and should be named in hacker_style() or it is
not trivial and should not be inlined.

[bcwhite, 2016/02/06 04:26:11]

Done.

+
+  // Ensure that the memory isn't so invalid that it won't crash when passing it
+  // to the allocator. This doesn't guarantee the data is valid, just that it
+  // won't cause the program to abort. The existing IsCorrupt() call will handle
+  // the rest.
+  static bool IsSharedMemoryAcceptable(const SharedMemory& mem);

[Alexei Svitkine (slow), 2016/02/05 21:54:02]

Hmm, it's hard to understand Acceptable without reading the comment. How about,
IsSharedMemoryValid()?

Also, |mem| -> |memory|.

[bcwhite, 2016/02/06 04:26:11]

It doesn't check that it's valid, just that it's acceptable to pass in without
causing a crash.  The check for "valid" would be too complex

+
+ private:
+  scoped_ptr<SharedMemory> shared_memory_;

[Alexei Svitkine (slow), 2016/02/05 21:54:02]

DISALLOW_COPY_AND_ASSIGN()

[bcwhite, 2016/02/06 04:26:11]

I always forget that...  below, too.

+};
+
+
 // This allocator takes a memory-mapped file object and performs allocation
 // from it. The allocator takes ownership of the file object. Only read access
 // is provided due to limitions of the MemoryMappedFile class.
 class BASE_EXPORT FilePersistentMemoryAllocator
     : public PersistentMemoryAllocator {
  public:
-  FilePersistentMemoryAllocator(MemoryMappedFile* file, uint64_t id,
+  FilePersistentMemoryAllocator(scoped_ptr<MemoryMappedFile> file, uint64_t id,
                                 const std::string& name);
   ~FilePersistentMemoryAllocator() override;
 
   // Ensure that the file isn't so invalid that it won't crash when passing it
   // to the allocator. This doesn't guarantee the file is valid, just that it
-  // won't cause program to abort. The existing IsCorrupt() call will handle
+  // won't cause the program to abort. The existing IsCorrupt() call will handle
   // the rest.
   static bool IsFileAcceptable(const MemoryMappedFile& file);
 
  private:
   scoped_ptr<MemoryMappedFile> mapped_file_;
 };
 
 }  // namespace base
 
 #endif  // BASE_METRICS_PERSISTENT_MEMORY_ALLOCATOR_H_