Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1660143006: Mojo C++ bindings: Move MakeProxy() -> InterfacePtr::Create(). (Closed)

Created:
4 years, 10 months ago by vardhan
Modified:
4 years, 10 months ago
Reviewers:
jamesr, viettrungluu
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Mojo C++ bindings: Move MakeProxy() -> InterfacePtr::Create(). And update its consumers. There are no consumers of mojo::MakeProxy() in the sky/flutter repo. R=jamesr@chromium.org, viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/eec2a350b080bc464d3023ae1d4f1e2fa20259d6

Patch Set 1 #

Patch Set 2 : fix failed 'gn' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -25 lines) Patch
M examples/ui/noodles/noodles_view.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/interface_ptr.h View 2 chunks +12 lines, -13 lines 0 comments Download
M mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/validation_unittest.cc View 2 chunks +4 lines, -2 lines 2 comments Download
M mojo/ui/ganesh_view.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/ui/gl_renderer_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/ui/gl_view.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M services/gfx/compositor/backend/gpu_output.cc View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
vardhan
ptal
4 years, 10 months ago (2016-02-04 17:52:42 UTC) #1
jamesr
lgtm
4 years, 10 months ago (2016-02-04 18:12:28 UTC) #2
vardhan
Committed patchset #2 (id:20001) manually as eec2a350b080bc464d3023ae1d4f1e2fa20259d6 (presubmit successful).
4 years, 10 months ago (2016-02-04 21:50:46 UTC) #4
viettrungluu
4 years, 10 months ago (2016-02-05 17:45:45 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/1660143006/diff/20001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/tests/validation_unittest.cc (right):

https://codereview.chromium.org/1660143006/diff/20001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/tests/validation_unittest.cc:9: #include <utility>
Hmmm, I don't think you actually added anything that requires this include.

https://codereview.chromium.org/1660143006/diff/20001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/tests/validation_unittest.cc:229:
ScopedMessagePipeHandle testee_endpoint() { return testee_endpoint_.Pass(); }
... though probably this "getter" having a severe side-effect is probably bad.

(It should probably be "ScopedMessagePipeHandle& testee_endpoint() { ... }".)

<shrug>

Powered by Google App Engine
This is Rietveld 408576698