Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(807)

Issue 1660083002: Drop the compileRun + asmCompileRun methods from wasm. (Closed)

Created:
4 years, 10 months ago by bradnelson
Modified:
4 years, 10 months ago
Reviewers:
titzer, aseemgarg, bradn
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Drop the compileRun + asmCompileRun methods from wasm. Now that we have full fledged module instantiation, keeping alive a second interface seems clunky. Droping it and switching the tests. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=test-asm-validator,asm-wasm,other wasm R=titzer@chromium.org,aseemgarg@chromium.org LOG=N Committed: https://crrev.com/255f4507ec53d53cea39b21821b1f6d32aa9aee6 Cr-Commit-Position: refs/heads/master@{#33700}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -136 lines) Patch
M src/wasm/wasm-js.cc View 3 chunks +1 line, -59 lines 0 comments Download
M test/mjsunit/regress/regress-575364.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/asm-wasm.js View 41 chunks +80 lines, -43 lines 0 comments Download
M test/mjsunit/wasm/compile-run-basic.js View 1 1 chunk +0 lines, -31 lines 0 comments Download
A + test/mjsunit/wasm/instantiate-run-basic.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/wasm-object-api.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
bradn
4 years, 10 months ago (2016-02-02 21:58:24 UTC) #2
aseemgarg
lgtm Rename compile-run-basic.js?
4 years, 10 months ago (2016-02-02 21:58:55 UTC) #3
bradn
renamed Ben, I wanted to wait for your sign-off too. Check the box if ok.
4 years, 10 months ago (2016-02-03 00:33:50 UTC) #4
titzer
On 2016/02/03 00:33:50, bradn wrote: > renamed > > Ben, I wanted to wait for ...
4 years, 10 months ago (2016-02-03 10:13:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1660083002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1660083002/20001
4 years, 10 months ago (2016-02-03 10:14:11 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-03 10:15:55 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 10:16:30 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/255f4507ec53d53cea39b21821b1f6d32aa9aee6
Cr-Commit-Position: refs/heads/master@{#33700}

Powered by Google App Engine
This is Rietveld 408576698