Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 1660073002: Fix fast/events/before-unload-return-bad-value.html (Closed)

Created:
4 years, 10 months ago by dcheng
Modified:
4 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix fast/events/before-unload-return-bad-value.html The onerror handler should be on the child frame's Window. BUG=446147 Committed: https://crrev.com/a6c49773a762aaf07a2ccb7f40fed53f0b589694 Cr-Commit-Position: refs/heads/master@{#373143}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M third_party/WebKit/LayoutTests/fast/events/before-unload-return-bad-value.html View 2 chunks +8 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/before-unload-return-bad-value-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
dcheng
Based on the blame and history of this test, I think this is the right ...
4 years, 10 months ago (2016-02-02 21:29:40 UTC) #2
haraken
LGTM
4 years, 10 months ago (2016-02-02 23:25:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1660073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1660073002/1
4 years, 10 months ago (2016-02-02 23:29:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-03 03:00:04 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 03:01:28 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a6c49773a762aaf07a2ccb7f40fed53f0b589694
Cr-Commit-Position: refs/heads/master@{#373143}

Powered by Google App Engine
This is Rietveld 408576698