Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 1660043004: SkMojo: generate on Darwin/x86_64 (Closed)

Created:
4 years, 10 months ago by hal.canary
Modified:
4 years, 10 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkMojo: generate on Darwin/x86_64 also clean up generate and skmojo.gyp to work right. BUG=skia:4891 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1660043004 Committed: https://skia.googlesource.com/skia/+/72002f28d5dc5c52df47393280154d3b446b7107

Patch Set 1 #

Total comments: 4

Patch Set 2 : comments from mtklein@ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -23 lines) Patch
M experimental/mojo/generate.py View 1 3 chunks +25 lines, -13 lines 0 comments Download
M gyp/skmojo.gyp View 1 3 chunks +40 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
hal.canary
ptal, small changes
4 years, 10 months ago (2016-02-03 20:35:41 UTC) #3
mtklein
lgtm https://codereview.chromium.org/1660043004/diff/1/experimental/mojo/generate.py File experimental/mojo/generate.py (right): https://codereview.chromium.org/1660043004/diff/1/experimental/mojo/generate.py#newcode33 experimental/mojo/generate.py:33: print url leftover debugging? https://codereview.chromium.org/1660043004/diff/1/gyp/skmojo.gyp File gyp/skmojo.gyp (right): ...
4 years, 10 months ago (2016-02-03 20:59:35 UTC) #4
hal.canary
https://codereview.chromium.org/1660043004/diff/1/experimental/mojo/generate.py File experimental/mojo/generate.py (right): https://codereview.chromium.org/1660043004/diff/1/experimental/mojo/generate.py#newcode33 experimental/mojo/generate.py:33: print url On 2016/02/03 at 20:59:34, mtklein wrote: > ...
4 years, 10 months ago (2016-02-03 21:23:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1660043004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1660043004/20001
4 years, 10 months ago (2016-02-03 21:23:54 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 21:54:06 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/72002f28d5dc5c52df47393280154d3b446b7107

Powered by Google App Engine
This is Rietveld 408576698