Issue 1659973002: Move ElementBuilder and CompilationUnitBuilder into builder.dart.

Issue 1659973002: Move ElementBuilder and CompilationUnitBuilder into builder.dart. (Closed)

Created:
4 years, 10 months ago by Paul Berry

Modified:
4 years, 10 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1088 lines, -1079 lines)			Patch
M	pkg/analyzer/lib/src/dart/element/builder.dart	View	2 chunks	+1084 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/incremental_resolver.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/resolver.dart	View	3 chunks	+0 lines, -1079 lines	0 comments	Download
M	pkg/analyzer/lib/src/task/incremental_element_builder.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/analyzer/test/generated/all_the_rest_test.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/analyzer/test/generated/incremental_resolver_test.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Brian Wilkerson

LGTM Technically this is a breaking change, but I'm hoping that it won't impact anyone. ...

4 years, 10 months ago (2016-02-02 18:39:14 UTC) #3

Paul Berry

4 years, 10 months ago (2016-02-02 20:27:09 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a7a028737d8a2961b8dab7e33eac4cec6a53d288 (presubmit successful).