[GCM] Make sure GCM checkout logic is invoked when the profile is signed out

google_apis/gcm/gcm_client.h

Index: google_apis/gcm/gcm_client.h
diff --git a/google_apis/gcm/gcm_client.h b/google_apis/gcm/gcm_client.h
index 8bb616d35cc80cbdae308b8fa46f38b5b072076c..971c8864a6221ce2096fa37597101cf80b486c6f 100644
--- a/google_apis/gcm/gcm_client.h
+++ b/google_apis/gcm/gcm_client.h
@@ -147,6 +147,9 @@ class GCM_EXPORT GCMClient {
           url_request_context_getter,
       Delegate* delegate) = 0;
 
+  // Loads the data from the persistent store and starts checking in with GCM.
+  virtual void CheckIn() = 0;

[Nicolas Zea, 2014/02/21 18:58:59]

Does it make more sense to call this Load() now? And mention that we'll
automatically check in if no store is found?

Although I wonder, should loading be part of initialize now, and we should just
have a separate Connect method (this would handle dealing with apps that
uninstall while we're suppressed).

I find it confusing that CheckIn will always load, but will only sometimes
actually perform a check-in. Especially since we'll have actual checkins
separate from load (the periodic ones).

[jianli, 2014/02/21 20:24:06]

Renamed to Load() added comment.
If the channel signal is off, we do not really need to load from the store.

We do need to refactor this to make the whole logic clean, but I would like to
do it later since we probably need to merge this patch to M34 branch.

+
   // Checks out of the GCM service. This will erase all the cached and persisted
   // data.
   virtual void CheckOut() = 0;
@@ -176,9 +179,6 @@ class GCM_EXPORT GCMClient {
   virtual void Send(const std::string& app_id,
                     const std::string& receiver_id,
                     const OutgoingMessage& message) = 0;
-
-  // Returns true if GCM becomes ready.
-  virtual bool IsReady() const = 0;
 };
 
 }  // namespace gcm