Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 1659903002: Fix background-size serializing (Closed)

Created:
4 years, 10 months ago by rwlbuis
Modified:
4 years, 10 months ago
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis, ashlin.j
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix background-size serializing The background-size property should be serialized as part of background shorthand property if it exists. However, the current serializing of background-size only works if there is any background-position given. Change the behavior to also serialize background-size if no background-position is given. Behavior matches Firefox. BUG=515087, 584664 Committed: https://crrev.com/d7198bc13bc8ce4af8644b299b95fcf82ef7a216 Cr-Commit-Position: refs/heads/master@{#374180}

Patch Set 1 #

Patch Set 2 : Add test #

Total comments: 2

Patch Set 3 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/fast/css/background-image-size-serialization.html View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css/background-image-size-serialization-expected.txt View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/StylePropertySerializer.cpp View 1 2 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
rwlbuis
PTAL.
4 years, 10 months ago (2016-02-03 21:35:38 UTC) #3
Timothy Loh
lgtm https://codereview.chromium.org/1659903002/diff/20001/third_party/WebKit/Source/core/css/StylePropertySerializer.cpp File third_party/WebKit/Source/core/css/StylePropertySerializer.cpp (right): https://codereview.chromium.org/1659903002/diff/20001/third_party/WebKit/Source/core/css/StylePropertySerializer.cpp#newcode713 third_party/WebKit/Source/core/css/StylePropertySerializer.cpp:713: if (foundPositionYCSSProperty) Maybe this should be: if (foundPositionXCSSProperty ...
4 years, 10 months ago (2016-02-08 05:29:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1659903002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1659903002/40001
4 years, 10 months ago (2016-02-08 15:14:14 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/19774)
4 years, 10 months ago (2016-02-08 17:48:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1659903002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1659903002/40001
4 years, 10 months ago (2016-02-08 18:00:34 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-08 21:25:25 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2016-02-08 21:26:29 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d7198bc13bc8ce4af8644b299b95fcf82ef7a216
Cr-Commit-Position: refs/heads/master@{#374180}

Powered by Google App Engine
This is Rietveld 408576698