Fix background-size serializing

Fix background-size serializing

The background-size property should be serialized as part of background
shorthand property if it exists. However, the current serializing of
background-size only works if there is any background-position given.
Change the behavior to also serialize background-size if no
background-position is given.

Behavior matches Firefox.

BUG=515087, 584664
Committed: https://crrev.com/d7198bc13bc8ce4af8644b299b95fcf82ef7a216
Cr-Commit-Position: refs/heads/master@{#374180}

[rwlbuis, 2016-02-03 21:33:01]

Description was changed from

==========
background-size WIP

BUG=
==========

to

==========
Fix background-size serializing

The background-size property should be serialized as part of background
shorthand property if it exists. However, the current serializing of
background-size only works if there is any background-position given.
Change the behavior to also serialize background-size if no
background-position is given.

Behavior matches Firefox.

BUG=515087
==========

[rwlbuis, 2016-02-03 21:35:38]

rob.buis@samsung.com changed reviewers:
+ meade@chromium.org, timloh@chromium.org

[rwlbuis, 2016-02-03 21:35:38]

PTAL.

[Timothy Loh, 2016-02-08 05:29:28]

lgtm

https://codereview.chromium.org/1659903002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/StylePropertySerializer.cpp (right):

https://codereview.chromium.org/1659903002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/StylePropertySerializer.cpp:713: if
(foundPositionYCSSProperty)
Maybe this should be:

if (foundPositionXCSSProperty || foundPositionYCSSProperty)
    " / "
else
    " 0% 0% / "

I think the current code will fail the position1 test if you changed
background-position to background-position-x. We might as well test that too.

https://codereview.chromium.org/1659903002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/StylePropertySerializer.cpp:733: if (property
== CSSPropertyBackgroundPositionX)
might as well check for CSSPropertyWebkitMaskPositionX too for consistency

[rwlbuis, 2016-02-08 15:13:13]

The CQ bit was checked by rob.buis@samsung.com

[rwlbuis, 2016-02-08 15:13:14]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/1659903002/#ps40001
(title: "Patch for landing")

[commit-bot: I haz the power, 2016-02-08 15:14:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1659903002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1659903002/40001

[rwlbuis, 2016-02-08 15:21:40]

Description was changed from

==========
Fix background-size serializing

The background-size property should be serialized as part of background
shorthand property if it exists. However, the current serializing of
background-size only works if there is any background-position given.
Change the behavior to also serialize background-size if no
background-position is given.

Behavior matches Firefox.

BUG=515087
==========

to

==========
Fix background-size serializing

The background-size property should be serialized as part of background
shorthand property if it exists. However, the current serializing of
background-size only works if there is any background-position given.
Change the behavior to also serialize background-size if no
background-position is given.

Behavior matches Firefox.

BUG=515087, 584664
==========

[commit-bot: I haz the power, 2016-02-08 17:48:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-08 17:48:12]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[rwlbuis, 2016-02-08 17:58:09]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2016-02-08 18:00:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1659903002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1659903002/40001

[commit-bot: I haz the power, 2016-02-08 21:25:24]

Description was changed from

==========
Fix background-size serializing

The background-size property should be serialized as part of background
shorthand property if it exists. However, the current serializing of
background-size only works if there is any background-position given.
Change the behavior to also serialize background-size if no
background-position is given.

Behavior matches Firefox.

BUG=515087, 584664
==========

to

==========
Fix background-size serializing

The background-size property should be serialized as part of background
shorthand property if it exists. However, the current serializing of
background-size only works if there is any background-position given.
Change the behavior to also serialize background-size if no
background-position is given.

Behavior matches Firefox.

BUG=515087, 584664
==========

[commit-bot: I haz the power, 2016-02-08 21:25:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-08 21:26:28]

Description was changed from

==========
Fix background-size serializing

The background-size property should be serialized as part of background
shorthand property if it exists. However, the current serializing of
background-size only works if there is any background-position given.
Change the behavior to also serialize background-size if no
background-position is given.

Behavior matches Firefox.

BUG=515087, 584664
==========

to

==========
Fix background-size serializing

The background-size property should be serialized as part of background
shorthand property if it exists. However, the current serializing of
background-size only works if there is any background-position given.
Change the behavior to also serialize background-size if no
background-position is given.

Behavior matches Firefox.

BUG=515087, 584664

Committed: https://crrev.com/d7198bc13bc8ce4af8644b299b95fcf82ef7a216
Cr-Commit-Position: refs/heads/master@{#374180}
==========

[commit-bot: I haz the power, 2016-02-08 21:26:29]

Patchset 3 (id:??) landed as
https://crrev.com/d7198bc13bc8ce4af8644b299b95fcf82ef7a216
Cr-Commit-Position: refs/heads/master@{#374180}