Source/core/html/HTMLInputElement.h - Issue 16599003: :hover style not applied on hover if its display property is different from original style's

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLInputElement.h

Issue 16599003: :hover style not applied on hover if its display property is different from original style's (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Patch (fixed test that was expected to fail and is now passing) Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLInputElement.h

diff --git a/Source/core/html/HTMLInputElement.h b/Source/core/html/HTMLInputElement.h

index 79bd788cbc41f909dbe71f3f4a9711658c050731..6b887b03e2d7f065feae0e981eb22619a6254f72 100644

--- a/Source/core/html/HTMLInputElement.h

+++ b/Source/core/html/HTMLInputElement.h

@@ -187,7 +187,7 @@ public:

virtual bool rendererIsNeeded(const NodeRenderingContext&);

virtual RenderObject* createRenderer(RenderArena*, RenderStyle*);

- virtual void detach();

+ virtual void detach(const AttachContext& = AttachContext()) OVERRIDE;

// FIXME: For isActivatedSubmit and setActivatedSubmit, we should use the NVI-idiom here by making

// it private virtual in all classes and expose a public method in HTMLFormControlElement to call

@@ -341,7 +341,7 @@ private:

virtual void copyNonAttributePropertiesFromElement(const Element&);

- virtual void attach();

+ virtual void attach(const AttachContext& = AttachContext()) OVERRIDE;

virtual bool appendFormData(FormDataList&, bool);

« no previous file with comments | « Source/core/html/HTMLImageElement.cpp ('k') | Source/core/html/HTMLInputElement.cpp » ('j') | no next file with comments »