Source/core/dom/PseudoElement.cpp - Issue 16599003: :hover style not applied on hover if its display property is different from original style's

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/PseudoElement.cpp

Issue 16599003: :hover style not applied on hover if its display property is different from original style's (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Patch (fixed test that was expected to fail and is now passing) Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/PseudoElement.cpp

diff --git a/Source/core/dom/PseudoElement.cpp b/Source/core/dom/PseudoElement.cpp

index 225ac0a816cfc7232d3a15bc267f6fadab5c5ee5..468883b63cc6996a0e213fcab5ba42a1f867b522 100644

--- a/Source/core/dom/PseudoElement.cpp

+++ b/Source/core/dom/PseudoElement.cpp

@@ -74,11 +74,11 @@ PassRefPtr<RenderStyle> PseudoElement::customStyleForRenderer()

return parentOrShadowHostElement()->renderer()->getCachedPseudoStyle(m_pseudoId);

}

-void PseudoElement::attach()

+void PseudoElement::attach(const AttachContext& context)

{

ASSERT(!renderer());

- Element::attach();

+ Element::attach(context);

RenderObject* renderer = this->renderer();

if (!renderer || !renderer->style()->regionThread().isEmpty())

« no previous file with comments | « Source/core/dom/PseudoElement.h ('k') | Source/core/dom/Text.h » ('j') | no next file with comments »