Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Side by Side Diff: Source/core/html/shadow/SliderThumbElement.cpp

Issue 16599003: :hover style not applied on hover if its display property is different from original style's (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch (fixed test that was expected to fail and is now passing) Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
3 * Copyright (C) 2010 Google Inc. All rights reserved. 3 * Copyright (C) 2010 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 370 matching lines...) Expand 10 before | Expand all | Expand 10 after
381 381
382 bool SliderThumbElement::willRespondToMouseClickEvents() 382 bool SliderThumbElement::willRespondToMouseClickEvents()
383 { 383 {
384 const HTMLInputElement* input = hostInput(); 384 const HTMLInputElement* input = hostInput();
385 if (input && !input->isDisabledOrReadOnly()) 385 if (input && !input->isDisabledOrReadOnly())
386 return true; 386 return true;
387 387
388 return HTMLDivElement::willRespondToMouseClickEvents(); 388 return HTMLDivElement::willRespondToMouseClickEvents();
389 } 389 }
390 390
391 void SliderThumbElement::detach() 391 void SliderThumbElement::detach(const AttachContext& context)
392 { 392 {
393 if (m_inDragMode) { 393 if (m_inDragMode) {
394 if (Frame* frame = document()->frame()) 394 if (Frame* frame = document()->frame())
395 frame->eventHandler()->setCapturingMouseEventsNode(0); 395 frame->eventHandler()->setCapturingMouseEventsNode(0);
396 } 396 }
397 HTMLDivElement::detach(); 397 HTMLDivElement::detach(context);
398 } 398 }
399 399
400 HTMLInputElement* SliderThumbElement::hostInput() const 400 HTMLInputElement* SliderThumbElement::hostInput() const
401 { 401 {
402 // Only HTMLInputElement creates SliderThumbElement instances as its shadow nodes. 402 // Only HTMLInputElement creates SliderThumbElement instances as its shadow nodes.
403 // So, shadowHost() must be an HTMLInputElement. 403 // So, shadowHost() must be an HTMLInputElement.
404 return toHTMLInputElement(shadowHost()); 404 return toHTMLInputElement(shadowHost());
405 } 405 }
406 406
407 static const AtomicString& sliderThumbShadowPseudoId() 407 static const AtomicString& sliderThumbShadowPseudoId()
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
469 case MediaVolumeSliderThumbPart: 469 case MediaVolumeSliderThumbPart:
470 case MediaFullScreenVolumeSliderPart: 470 case MediaFullScreenVolumeSliderPart:
471 case MediaFullScreenVolumeSliderThumbPart: 471 case MediaFullScreenVolumeSliderThumbPart:
472 return mediaSliderContainer; 472 return mediaSliderContainer;
473 default: 473 default:
474 return sliderContainer; 474 return sliderContainer;
475 } 475 }
476 } 476 }
477 477
478 } 478 }
OLDNEW
« no previous file with comments | « Source/core/html/shadow/SliderThumbElement.h ('k') | Source/core/html/shadow/SpinButtonElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698