Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Side by Side Diff: Source/core/html/HTMLPlugInElement.cpp

Issue 16599003: :hover style not applied on hover if its display property is different from original style's (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch (fixed test that was expected to fail and is now passing) Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/HTMLPlugInElement.h ('k') | Source/core/html/HTMLPlugInImageElement.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /** 1 /**
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de) 4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de)
5 * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc. 5 * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 if (isDisabledFormControl()) 72 if (isDisabledFormControl())
73 return false; 73 return false;
74 RenderObject* r = renderer(); 74 RenderObject* r = renderer();
75 if (!r) 75 if (!r)
76 return false; 76 return false;
77 if (!r->isEmbeddedObject() && !r->isWidget()) 77 if (!r->isEmbeddedObject() && !r->isWidget())
78 return false; 78 return false;
79 return true; 79 return true;
80 } 80 }
81 81
82 void HTMLPlugInElement::detach() 82 void HTMLPlugInElement::detach(const AttachContext& context)
83 { 83 {
84 m_instance.clear(); 84 m_instance.clear();
85 85
86 if (m_isCapturingMouseEvents) { 86 if (m_isCapturingMouseEvents) {
87 if (Frame* frame = document()->frame()) 87 if (Frame* frame = document()->frame())
88 frame->eventHandler()->setCapturingMouseEventsNode(0); 88 frame->eventHandler()->setCapturingMouseEventsNode(0);
89 m_isCapturingMouseEvents = false; 89 m_isCapturingMouseEvents = false;
90 } 90 }
91 91
92 if (m_NPObject) { 92 if (m_NPObject) {
93 _NPN_ReleaseObject(m_NPObject); 93 _NPN_ReleaseObject(m_NPObject);
94 m_NPObject = 0; 94 m_NPObject = 0;
95 } 95 }
96 96
97 HTMLFrameOwnerElement::detach(); 97 HTMLFrameOwnerElement::detach(context);
98 } 98 }
99 99
100 void HTMLPlugInElement::resetInstance() 100 void HTMLPlugInElement::resetInstance()
101 { 101 {
102 m_instance.clear(); 102 m_instance.clear();
103 } 103 }
104 104
105 PassScriptInstance HTMLPlugInElement::getInstance() 105 PassScriptInstance HTMLPlugInElement::getInstance()
106 { 106 {
107 Frame* frame = document()->frame(); 107 Frame* frame = document()->frame();
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
230 230
231 NPObject* HTMLPlugInElement::getNPObject() 231 NPObject* HTMLPlugInElement::getNPObject()
232 { 232 {
233 ASSERT(document()->frame()); 233 ASSERT(document()->frame());
234 if (!m_NPObject) 234 if (!m_NPObject)
235 m_NPObject = document()->frame()->script()->createScriptObjectForPluginE lement(this); 235 m_NPObject = document()->frame()->script()->createScriptObjectForPluginE lement(this);
236 return m_NPObject; 236 return m_NPObject;
237 } 237 }
238 238
239 } 239 }
OLDNEW
« no previous file with comments | « Source/core/html/HTMLPlugInElement.h ('k') | Source/core/html/HTMLPlugInImageElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698