Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Side by Side Diff: Source/core/html/HTMLFrameElement.cpp

Issue 16599003: :hover style not applied on hover if its display property is different from original style's (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch (fixed test that was expected to fail and is now passing) Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/HTMLFrameElement.h ('k') | Source/core/html/HTMLFrameElementBase.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Simon Hausmann (hausmann@kde.org) 4 * (C) 2000 Simon Hausmann (hausmann@kde.org)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2004, 2006, 2009 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2006, 2009 Apple Inc. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 return static_cast<HTMLFrameSetElement*>(node); 64 return static_cast<HTMLFrameSetElement*>(node);
65 } 65 }
66 return 0; 66 return 0;
67 } 67 }
68 68
69 bool HTMLFrameElement::noResize() const 69 bool HTMLFrameElement::noResize() const
70 { 70 {
71 return hasAttribute(noresizeAttr); 71 return hasAttribute(noresizeAttr);
72 } 72 }
73 73
74 void HTMLFrameElement::attach() 74 void HTMLFrameElement::attach(const AttachContext& context)
75 { 75 {
76 HTMLFrameElementBase::attach(); 76 HTMLFrameElementBase::attach(context);
77 77
78 if (HTMLFrameSetElement* frameSetElement = containingFrameSetElement(this)) { 78 if (HTMLFrameSetElement* frameSetElement = containingFrameSetElement(this)) {
79 if (!m_frameBorderSet) 79 if (!m_frameBorderSet)
80 m_frameBorder = frameSetElement->hasFrameBorder(); 80 m_frameBorder = frameSetElement->hasFrameBorder();
81 } 81 }
82 } 82 }
83 83
84 void HTMLFrameElement::parseAttribute(const QualifiedName& name, const AtomicStr ing& value) 84 void HTMLFrameElement::parseAttribute(const QualifiedName& name, const AtomicStr ing& value)
85 { 85 {
86 if (name == frameborderAttr) { 86 if (name == frameborderAttr) {
87 m_frameBorder = value.toInt(); 87 m_frameBorder = value.toInt();
88 m_frameBorderSet = !value.isNull(); 88 m_frameBorderSet = !value.isNull();
89 // FIXME: If we are already attached, this has no effect. 89 // FIXME: If we are already attached, this has no effect.
90 } else if (name == noresizeAttr) { 90 } else if (name == noresizeAttr) {
91 if (renderer()) 91 if (renderer())
92 renderer()->updateFromElement(); 92 renderer()->updateFromElement();
93 } else 93 } else
94 HTMLFrameElementBase::parseAttribute(name, value); 94 HTMLFrameElementBase::parseAttribute(name, value);
95 } 95 }
96 96
97 } // namespace WebCore 97 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/html/HTMLFrameElement.h ('k') | Source/core/html/HTMLFrameElementBase.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698