Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Side by Side Diff: Source/core/dom/PseudoElement.h

Issue 16599003: :hover style not applied on hover if its display property is different from original style's (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch (fixed test that was expected to fail and is now passing) Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/NodeRenderingContext.cpp ('k') | Source/core/dom/PseudoElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Neither the name of Google Inc. nor the names of its 10 * * Neither the name of Google Inc. nor the names of its
(...skipping 25 matching lines...) Expand all
36 36
37 class PseudoElement FINAL : public Element { 37 class PseudoElement FINAL : public Element {
38 public: 38 public:
39 static PassRefPtr<PseudoElement> create(Element* parent, PseudoId pseudoId) 39 static PassRefPtr<PseudoElement> create(Element* parent, PseudoId pseudoId)
40 { 40 {
41 return adoptRef(new PseudoElement(parent, pseudoId)); 41 return adoptRef(new PseudoElement(parent, pseudoId));
42 } 42 }
43 ~PseudoElement(); 43 ~PseudoElement();
44 44
45 virtual PassRefPtr<RenderStyle> customStyleForRenderer() OVERRIDE; 45 virtual PassRefPtr<RenderStyle> customStyleForRenderer() OVERRIDE;
46 virtual void attach() OVERRIDE; 46 virtual void attach(const AttachContext& = AttachContext()) OVERRIDE;
47 virtual bool rendererIsNeeded(const NodeRenderingContext&) OVERRIDE; 47 virtual bool rendererIsNeeded(const NodeRenderingContext&) OVERRIDE;
48 48
49 virtual bool canStartSelection() const OVERRIDE { return false; } 49 virtual bool canStartSelection() const OVERRIDE { return false; }
50 virtual bool canContainRangeEndPoint() const OVERRIDE { return false; } 50 virtual bool canContainRangeEndPoint() const OVERRIDE { return false; }
51 51
52 static String pseudoElementNameForEvents(PseudoId); 52 static String pseudoElementNameForEvents(PseudoId);
53 53
54 private: 54 private:
55 PseudoElement(Element*, PseudoId); 55 PseudoElement(Element*, PseudoId);
56 56
57 virtual void didRecalcStyle(StyleChange) OVERRIDE; 57 virtual void didRecalcStyle(StyleChange) OVERRIDE;
58 virtual PseudoId customPseudoId() const OVERRIDE { return m_pseudoId; } 58 virtual PseudoId customPseudoId() const OVERRIDE { return m_pseudoId; }
59 59
60 PseudoId m_pseudoId; 60 PseudoId m_pseudoId;
61 }; 61 };
62 62
63 const QualifiedName& pseudoElementTagName(); 63 const QualifiedName& pseudoElementTagName();
64 64
65 inline bool pseudoElementRendererIsNeeded(const RenderStyle* style) 65 inline bool pseudoElementRendererIsNeeded(const RenderStyle* style)
66 { 66 {
67 return style && style->display() != NONE && (style->contentData() || !style- >regionThread().isEmpty()); 67 return style && style->display() != NONE && (style->contentData() || !style- >regionThread().isEmpty());
68 } 68 }
69 69
70 } // namespace 70 } // namespace
71 71
72 #endif 72 #endif
OLDNEW
« no previous file with comments | « Source/core/dom/NodeRenderingContext.cpp ('k') | Source/core/dom/PseudoElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698