Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Side by Side Diff: Source/core/html/HTMLInputElement.cpp

Issue 16599003: :hover style not applied on hover if its display property is different from original style's (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 10 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
(...skipping 800 matching lines...) Expand 10 before | Expand all | Expand 10 after
811 bool HTMLInputElement::rendererIsNeeded(const NodeRenderingContext& context) 811 bool HTMLInputElement::rendererIsNeeded(const NodeRenderingContext& context)
812 { 812 {
813 return m_inputType->rendererIsNeeded() && HTMLTextFormControlElement::render erIsNeeded(context); 813 return m_inputType->rendererIsNeeded() && HTMLTextFormControlElement::render erIsNeeded(context);
814 } 814 }
815 815
816 RenderObject* HTMLInputElement::createRenderer(RenderArena* arena, RenderStyle* style) 816 RenderObject* HTMLInputElement::createRenderer(RenderArena* arena, RenderStyle* style)
817 { 817 {
818 return m_inputType->createRenderer(arena, style); 818 return m_inputType->createRenderer(arena, style);
819 } 819 }
820 820
821 void HTMLInputElement::attach() 821 void HTMLInputElement::attach(const AttachContext& context)
822 { 822 {
823 PostAttachCallbackDisabler disabler(this); 823 PostAttachCallbackDisabler disabler(this);
824 824
825 if (!m_hasType) 825 if (!m_hasType)
826 updateType(); 826 updateType();
827 827
828 HTMLTextFormControlElement::attach(); 828 HTMLTextFormControlElement::attach(context);
829 829
830 m_inputType->attach(); 830 m_inputType->attach();
831 831
832 if (document()->focusedNode() == this) 832 if (document()->focusedNode() == this)
833 document()->updateFocusAppearanceSoon(true /* restore selection */); 833 document()->updateFocusAppearanceSoon(true /* restore selection */);
834 } 834 }
835 835
836 void HTMLInputElement::detach() 836 void HTMLInputElement::detach(const AttachContext& context)
837 { 837 {
838 HTMLTextFormControlElement::detach(); 838 HTMLTextFormControlElement::detach(context);
839 setFormControlValueMatchesRenderer(false); 839 setFormControlValueMatchesRenderer(false);
840 m_inputType->detach(); 840 m_inputType->detach();
841 } 841 }
842 842
843 String HTMLInputElement::altText() const 843 String HTMLInputElement::altText() const
844 { 844 {
845 // http://www.w3.org/TR/1998/REC-html40-19980424/appendix/notes.html#altgen 845 // http://www.w3.org/TR/1998/REC-html40-19980424/appendix/notes.html#altgen
846 // also heavily discussed by Hixie on bugzilla 846 // also heavily discussed by Hixie on bugzilla
847 // note this is intentionally different to HTMLImageElement::altText() 847 // note this is intentionally different to HTMLImageElement::altText()
848 String alt = fastGetAttribute(altAttr); 848 String alt = fastGetAttribute(altAttr);
(...skipping 1081 matching lines...) Expand 10 before | Expand all | Expand 10 after
1930 } 1930 }
1931 1931
1932 #if ENABLE(INPUT_MULTIPLE_FIELDS_UI) 1932 #if ENABLE(INPUT_MULTIPLE_FIELDS_UI)
1933 PassRefPtr<RenderStyle> HTMLInputElement::customStyleForRenderer() 1933 PassRefPtr<RenderStyle> HTMLInputElement::customStyleForRenderer()
1934 { 1934 {
1935 return m_inputType->customStyleForRenderer(originalStyleForRenderer()); 1935 return m_inputType->customStyleForRenderer(originalStyleForRenderer());
1936 } 1936 }
1937 #endif 1937 #endif
1938 1938
1939 } // namespace 1939 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698