Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 1659883002: Reland of MIPS: Add FPXX support to MIPS32R2 (Closed)

Created:
4 years, 10 months ago by ivica.bogosavljevic
Modified:
4 years, 10 months ago
Reviewers:
ilija.pavlovic, balazs.kilvady, miran.karic, Marija Antic, gergely.kis.imgtec, akos.palfi.imgtec
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of MIPS: Add FPXX support to MIPS32R2 Fix failures on MIPS simulator because incomplete handling of MTHC1 and MFHC1 in Fp32 mode Fix failures on older kernels that have problems with MTHC1 and MFHC1 in kernel FPU emulation Original issue's description: > Revert of MIPS: Add FPXX support to MIPS32R2 (patchset #3 > id:40001 of https://codereview.chromium.org/1586223004/ ) > > Reason for revert: > Revert patch due to a number of failures appearing on the > MIPS v8 simulator > > Original issue's description: >> MIPS: Add FPXX support to MIPS32R2 >> >> The JIT code generated by V8 is FPXX compliant >> when v8 compiled with FPXX flag. This allows the code to >> run in both FP=1 and FP=0 mode. It also alows v8 to be used >> as a library by both FP32 and FP64 binaries. >> >> BUG= >> >> Committed: https://crrev.com/95110dde666158a230a823fd50a68558ad772320 >> Cr-Commit-Position: refs/heads/master@{#33576} BUG= Committed: https://crrev.com/b23d5389e024a85cdc5c7d343fe5cc68a14f4d49 Cr-Commit-Position: refs/heads/master@{#33808}

Patch Set 1 : Original patchset that was reverted later #

Patch Set 2 : Fix simulator failures. Use MTC1 and MFC1 in FP32 mode #

Patch Set 3 : Fix failure in RunFloat64InsertLowWord32 test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -60 lines) Patch
M src/mips/assembler-mips.cc View 1 2 chunks +30 lines, -24 lines 0 comments Download
M src/mips/constants-mips.h View 2 chunks +9 lines, -9 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 2 2 chunks +15 lines, -9 lines 0 comments Download
M src/mips/simulator-mips.cc View 1 2 chunks +10 lines, -2 lines 0 comments Download
M test/cctest/test-assembler-mips.cc View 6 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
ivica.bogosavljevic
PTAL
4 years, 10 months ago (2016-02-04 11:27:28 UTC) #4
Ilija.Pavlovic1
The patch seems to me OK.
4 years, 10 months ago (2016-02-04 13:03:43 UTC) #6
akos.palfi.imgtec
Lgtm
4 years, 10 months ago (2016-02-04 16:30:22 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1659883002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1659883002/40001
4 years, 10 months ago (2016-02-08 09:10:33 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-08 09:28:44 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1659883002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1659883002/40001
4 years, 10 months ago (2016-02-08 09:42:42 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-08 09:44:05 UTC) #17
commit-bot: I haz the power
4 years, 10 months ago (2016-02-08 09:44:25 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b23d5389e024a85cdc5c7d343fe5cc68a14f4d49
Cr-Commit-Position: refs/heads/master@{#33808}

Powered by Google App Engine
This is Rietveld 408576698