Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1659853002: Fix one more DCHECK for FAST_STRING_WRAPPER_ELEMENTS (Closed)

Created:
4 years, 10 months ago by Jakob Kummerow
Modified:
4 years, 10 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix one more DCHECK for FAST_STRING_WRAPPER_ELEMENTS This is a follow-up fix to f4872f74 / r33616. Committed: https://crrev.com/6da816198eb61e1f33110f14199d4385d5a66225 Cr-Commit-Position: refs/heads/master@{#33667}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/elements.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Jakob Kummerow
4 years, 10 months ago (2016-02-02 09:43:34 UTC) #2
Yang
On 2016/02/02 09:43:34, Jakob wrote: lgtm.
4 years, 10 months ago (2016-02-02 09:44:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1659853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1659853002/1
4 years, 10 months ago (2016-02-02 09:45:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-02 10:14:31 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 10:14:59 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6da816198eb61e1f33110f14199d4385d5a66225
Cr-Commit-Position: refs/heads/master@{#33667}

Powered by Google App Engine
This is Rietveld 408576698