Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 1659833002: Apply an overlooked patch to brkitr/word.txt (Closed)

Created:
4 years, 10 months ago by jungshik at Google
Modified:
4 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Apply an overlooked patch to brkitr/word.txt patches/wordbrk.patch was not applied by mistake while updating ICU to 56.1. This affects how we break domain names (separated by full stop). We want them to be split at full stop at the cost of 'breaking' cases like "e.g." and "i.e.". All the ICU data files were rebuilt for the change. BUG=575007 TEST=gfx_unittests --gtest_filter=RenderText*Word* TEST=layout tests: css1/text_properties/text_transform.html fast/text/window-find.html editing/text-iterator/findString.html css2.1/t1605-c545-txttrans-00-b-ag.html Committed: https://chromium.googlesource.com/chromium/deps/icu/+/452b580a4e6d73aac8f097d792da98ab6644019a

Patch Set 1 #

Patch Set 2 : add data files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M android/icudtl.dat View 1 Binary file 0 comments Download
M source/data/brkitr/word.txt View 1 chunk +9 lines, -3 lines 0 comments Download
M source/data/in/icudtl.dat View 1 Binary file 0 comments Download
M windows/icudt.dll View 1 Binary file 0 comments Download

Messages

Total messages: 5 (4 generated)
jungshik at Google
4 years, 10 months ago (2016-02-03 23:42:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
452b580a4e6d73aac8f097d792da98ab6644019a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698