Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 165983007: Return ERR_INVALID_RESPONSE when we get a funky error page mime-type. (Closed)

Created:
6 years, 10 months ago by mmenke
Modified:
6 years, 10 months ago
Reviewers:
davidben
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Return ERR_INVALID_RESPONSE when we get a funky error page mime-type. ERR_FILE_NOT_FOUND was being returned before, which is rather misleading. ERR_INVALID_RESPONSE is a very rare error, and currently just uses the generic error page, with no strings of its own. If this CL significantly increases the frequency of the error, we should add strings for it. BUG=344633 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252163

Patch Set 1 #

Patch Set 2 : Update test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M content/browser/loader/buffered_resource_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
mmenke
A Googler pointed out to me how little sense this error code made. The new ...
6 years, 10 months ago (2014-02-19 20:16:14 UTC) #1
davidben
On 2014/02/19 20:16:14, mmenke wrote: > A Googler pointed out to me how little sense ...
6 years, 10 months ago (2014-02-19 20:18:43 UTC) #2
mmenke
The CQ bit was checked by mmenke@chromium.org
6 years, 10 months ago (2014-02-19 20:20:14 UTC) #3
mmenke
On 2014/02/19 20:18:43, David Benjamin wrote: > On 2014/02/19 20:16:14, mmenke wrote: > > A ...
6 years, 10 months ago (2014-02-19 20:23:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/165983007/220001
6 years, 10 months ago (2014-02-19 20:25:10 UTC) #5
mmenke
The CQ bit was unchecked by mmenke@chromium.org
6 years, 10 months ago (2014-02-19 22:29:12 UTC) #6
mmenke
The CQ bit was checked by mmenke@chromium.org
6 years, 10 months ago (2014-02-19 22:29:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/165983007/220001
6 years, 10 months ago (2014-02-20 00:22:16 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-20 02:29:12 UTC) #9
Message was sent while issue was closed.
Change committed as 252163

Powered by Google App Engine
This is Rietveld 408576698