[AudioPlayer] Regenerate play order when is is insufficient

[AudioPlayer] Regenerate play order when is is insufficient

BUG=342593
TEST=manually tested

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251953

[yoshiki, 2014-02-14 05:48:49]

hirono, PTAL. Thanks.

[hirono, 2014-02-14 07:33:32]

https://codereview.chromium.org/165983002/diff/1/chrome/browser/resources/fil...
File chrome/browser/resources/file_manager/audio_player/elements/track_list.js
(right):

https://codereview.chromium.org/165983002/diff/1/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/audio_player/elements/track_list.js:92:
this.generatePlayOrder(true /* need to keep the current track */);
I'm not sure why the case is happened.
When the tracks is change, we generate the play order.
Does not enough to sync the order?

[yoshiki, 2014-02-14 08:46:21]

On 2014/02/14 07:33:32, hirono wrote:
>
https://codereview.chromium.org/165983002/diff/1/chrome/browser/resources/fil...
> File chrome/browser/resources/file_manager/audio_player/elements/track_list.js
> (right):
> 
>
https://codereview.chromium.org/165983002/diff/1/chrome/browser/resources/fil...
> chrome/browser/resources/file_manager/audio_player/elements/track_list.js:92:
> this.generatePlayOrder(true /* need to keep the current track */);
> I'm not sure why the case is happened.
> When the tracks is change, we generate the play order.
> Does not enough to sync the order?

Thanks for a comment from good view. I found the root causes and fix them. PTAL?

[hirono, 2014-02-14 08:55:22]

Thanks! lgtm with a nit.

https://codereview.chromium.org/165983002/diff/60001/chrome/browser/resources...
File chrome/browser/resources/file_manager/audio_player/elements/track_list.js
(right):

https://codereview.chromium.org/165983002/diff/60001/chrome/browser/resources...
chrome/browser/resources/file_manager/audio_player/elements/track_list.js:100: *
Invoked when 'tracks' property is clicked.
nit: Fix the doc.

[yoshiki, 2014-02-18 02:01:22]

The CQ bit was checked by yoshiki@chromium.org

[commit-bot: I haz the power, 2014-02-18 02:01:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/165983002/60001

[commit-bot: I haz the power, 2014-02-18 02:52:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-18 02:52:12]

Retried try job too often on win_rel for step(s) telemetry_perf_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[yoshiki, 2014-02-19 02:02:52]

The CQ bit was checked by yoshiki@chromium.org

[commit-bot: I haz the power, 2014-02-19 02:03:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/165983002/60001

[commit-bot: I haz the power, 2014-02-19 06:00:27]

Change committed as 251953