src/heap/mark-compact.cc - Issue 1659823002: [heap] Slightly optimize Heap::UpdateAllocationSite()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/mark-compact.cc

Issue 1659823002: [heap] Slightly optimize Heap::UpdateAllocationSite() (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap/mark-compact.cc

diff --git a/src/heap/mark-compact.cc b/src/heap/mark-compact.cc

index 3e5dafe345a481f08f88f20fd971db40e8894af7..fa55649db2f6de4e9ca362b093d86356a68bbbc8 100644

--- a/src/heap/mark-compact.cc

+++ b/src/heap/mark-compact.cc

@@ -1571,7 +1571,8 @@ class MarkCompactCollector::EvacuateNewSpaceVisitor final

local_pretenuring_feedback_(local_pretenuring_feedback) {}

bool Visit(HeapObject* object) override {

- heap_->UpdateAllocationSite(object, local_pretenuring_feedback_);

+ heap_->UpdateAllocationSite<Heap::kCached>(object,

+ local_pretenuring_feedback_);

int size = object->Size();

HeapObject* target_object = nullptr;

if (heap_->ShouldBePromoted(object->address(), size) &&