Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 1659823002: [heap] Slightly optimize Heap::UpdateAllocationSite() (Closed)

Created:
4 years, 10 months ago by Michael Lippautz
Modified:
4 years, 10 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Slightly optimize Heap::UpdateAllocationSite() This function is called for every live object in new space. We statically know which version to call, so let's use templates here and eliminite a branch at runtime. BUG=chromium:524425 LOG=N Committed: https://crrev.com/062fc9abcf0528e77d88ee9bf7b66b799e94d10f Cr-Commit-Position: refs/heads/master@{#33662}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M src/heap/heap.h View 2 chunks +6 lines, -5 lines 1 comment Download
M src/heap/heap-inl.h View 3 chunks +5 lines, -2 lines 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/heap/scavenger-inl.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1659823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1659823002/1
4 years, 10 months ago (2016-02-02 08:36:47 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-02 09:03:38 UTC) #6
Michael Lippautz
https://codereview.chromium.org/1659823002/diff/1/src/heap/heap.h File src/heap/heap.h (left): https://codereview.chromium.org/1659823002/diff/1/src/heap/heap.h#oldcode451 src/heap/heap.h:451: enum PretenuringFeedbackInsertionMode { kCached, kGlobal }; We already had ...
4 years, 10 months ago (2016-02-02 09:15:35 UTC) #8
ulan
lgtm
4 years, 10 months ago (2016-02-02 09:24:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1659823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1659823002/1
4 years, 10 months ago (2016-02-02 09:25:57 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-02 09:28:10 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 09:29:01 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/062fc9abcf0528e77d88ee9bf7b66b799e94d10f
Cr-Commit-Position: refs/heads/master@{#33662}

Powered by Google App Engine
This is Rietveld 408576698