Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 1659713002: UBSan: Add blacklist files for libyuvC standalone. (Closed)

Created:
4 years, 10 months ago by fbarchard1
Modified:
4 years, 10 months ago
Reviewers:
harryjin, pbos-webrtc, pbos
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

UBSan: Add blacklist files for libyuvC standalone. For more info, see http://dev.chromium.org/developers/testing/undefinedbehaviorsanitizer TESTED=Passing compilation using: GYP_DEFINES="ubsan=1" GYP_DEFINES="ubsan_vptr=1" R=harryjin@google.com, pbos@webrtc.org BUG=libyuv:563, webrtc:5124 Committed: https://chromium.googlesource.com/libyuv/libyuv/+/0e7d2926e29eb173f88c627187174af16d1c1f51

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
A tools/ubsan/OWNERS View 1 chunk +4 lines, -0 lines 0 comments Download
A tools/ubsan/blacklist.txt View 1 chunk +15 lines, -0 lines 1 comment Download
A tools/ubsan/vptr_blacklist.txt View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fbarchard1
4 years, 10 months ago (2016-02-01 23:45:51 UTC) #1
harryjin
lgtm
4 years, 10 months ago (2016-02-02 01:17:14 UTC) #2
fbarchard1
Committed patchset #1 (id:1) manually as 0e7d2926e29eb173f88c627187174af16d1c1f51 (presubmit successful).
4 years, 10 months ago (2016-02-02 02:08:57 UTC) #4
pbos
4 years, 10 months ago (2016-02-02 13:07:25 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/1659713002/diff/1/tools/ubsan/blacklist.txt
File tools/ubsan/blacklist.txt (right):

https://codereview.chromium.org/1659713002/diff/1/tools/ubsan/blacklist.txt#n...
tools/ubsan/blacklist.txt:6: # adding WebRTC-specific blacklist entries.
This should probably state libyuv. :)

Powered by Google App Engine
This is Rietveld 408576698