Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: third_party/WebKit/public/platform/WebSourceBufferClient.h

Issue 1659653002: Pass MSE media track info from ChunkDemuxer to blink::SourceBuffer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@use-media-tracks-in-media
Patch Set: nit Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/public/platform/WebMediaPlayer.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/platform/WebSourceBufferClient.h
diff --git a/third_party/WebKit/public/platform/WebSourceBufferClient.h b/third_party/WebKit/public/platform/WebSourceBufferClient.h
index 849f2824bac215a5f44ac48dda0319e928ed3d7f..dccfcc87b804d5957eea61231c7f17cf1e38e2bb 100644
--- a/third_party/WebKit/public/platform/WebSourceBufferClient.h
+++ b/third_party/WebKit/public/platform/WebSourceBufferClient.h
@@ -5,14 +5,25 @@
#ifndef WebSourceBufferClient_h
#define WebSourceBufferClient_h
+#include "WebMediaPlayer.h"
+#include "WebString.h"
+
+#include <tuple>
+#include <vector>
+
namespace blink {
class WebSourceBufferClient {
public:
virtual ~WebSourceBufferClient() { }
- // FIXME: Add a track collection parameter here.
- virtual void initializationSegmentReceived() = 0;
+ // Complete media track info: track type, bytestream id, kind, label, language.
+ typedef std::tuple<WebMediaPlayer::TrackType, WebString, WebString, WebString, WebString> MediaTrackInfo;
esprehn 2016/04/12 18:44:10 please define structs instead of making huge tuple
servolk 2016/04/15 20:34:26 Ok, but this CL has already been merged, so I've c
+
+ // Notifies SourceBuffer that parsing of a new init segment has been completed successfully. The input parameter is a collection
+ // of information about media tracks found in the new init segment. The return value is a vector of blink WebMediaPlayer track ids
+ // assigned to each track of the input collection (the order of output track ids must match the input track information).
+ virtual std::vector<WebMediaPlayer::TrackId> initializationSegmentReceived(const std::vector<MediaTrackInfo>& tracks) = 0;
esprehn 2016/04/12 18:44:10 This should be WebVector, not std::vector.
servolk 2016/04/15 20:34:26 Done: https://codereview.chromium.org/1897533002
};
} // namespace blink
« no previous file with comments | « third_party/WebKit/public/platform/WebMediaPlayer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698