third_party/WebKit/Source/core/html/track/TrackBase.h - Issue 1659653002: Pass MSE media track info from ChunkDemuxer to blink::SourceBuffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/track/TrackBase.h

Issue 1659653002: Pass MSE media track info from ChunkDemuxer to blink::SourceBuffer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@use-media-tracks-in-media

Patch Set: CR feedback2 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/track/TextTrack.cpp ('k') | third_party/WebKit/Source/core/html/track/TrackBase.cpp » ('j') | third_party/WebKit/Source/modules/mediasource/SourceBuffer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/track/TrackBase.h

diff --git a/third_party/WebKit/Source/core/html/track/TrackBase.h b/third_party/WebKit/Source/core/html/track/TrackBase.h

index 4a71790195bedd7e70d6f4d798051bfa35f33df3..0033635fc9a908e7884ea466bfe12cf2e3f1fe75 100644

--- a/third_party/WebKit/Source/core/html/track/TrackBase.h

+++ b/third_party/WebKit/Source/core/html/track/TrackBase.h

@@ -42,8 +42,7 @@ public:

WebMediaPlayer::TrackId trackId() const { return m_trackId; }

- enum TrackType { TextTrack, AudioTrack, VideoTrack };

- TrackType type() const { return m_type; }

+ WebMediaPlayer::TrackType type() const { return m_type; }

const AtomicString& kind() const { return m_kind; }

virtual void setKind(const AtomicString&);

@@ -64,14 +63,14 @@ public:

DECLARE_VIRTUAL_TRACE();

protected:

- TrackBase(TrackType, const AtomicString& label, const AtomicString& language, const String& id);

+ TrackBase(WebMediaPlayer::TrackType, const AtomicString& label, const AtomicString& language, const String& id);

virtual bool isValidKind(const AtomicString&) const = 0;

virtual AtomicString defaultKind() const = 0;

private:

WebMediaPlayer::TrackId m_trackId;

- TrackType m_type;

+ WebMediaPlayer::TrackType m_type;

AtomicString m_kind;

AtomicString m_label;

AtomicString m_language;