media/blink/webmediaplayer_impl.cc - Issue 1659653002: Pass MSE media track info from ChunkDemuxer to blink::SourceBuffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/blink/webmediaplayer_impl.cc

Issue 1659653002: Pass MSE media track info from ChunkDemuxer to blink::SourceBuffer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@use-media-tracks-in-media

Patch Set: CR feedback2 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/blink/webmediaplayer_impl.cc

diff --git a/media/blink/webmediaplayer_impl.cc b/media/blink/webmediaplayer_impl.cc

index 071e70ea84795f1ee587582696245009946f7175..27099f5bb8c0023057c397cc1db3b2b56c1b1b49 100644

--- a/media/blink/webmediaplayer_impl.cc

+++ b/media/blink/webmediaplayer_impl.cc

@@ -991,7 +991,7 @@ void WebMediaPlayerImpl::OnAddTextTrack(

scoped_ptr<WebInbandTextTrackImpl> web_inband_text_track(

new WebInbandTextTrackImpl(web_kind, web_label, web_language, web_id));

- scoped_ptr<TextTrack> text_track(new TextTrackImpl(

+ scoped_ptr<media::TextTrack> text_track(new TextTrackImpl(

main_task_runner_, client_, std::move(web_inband_text_track)));

done_cb.Run(std::move(text_track));

« no previous file with comments | « no previous file | media/blink/websourcebuffer_impl.cc » ('j') | third_party/WebKit/Source/modules/mediasource/SourceBuffer.h » ('J')