Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1659633003: Abort if a patch set title is provided for a Gerrit server (Closed)

Created:
4 years, 10 months ago by Bons
Modified:
4 years, 10 months ago
Reviewers:
tandrii(chromium)
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Abort if a patch set title is provided for a Gerrit server Gerrit doesn’t support patch titles. BUG=579178 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298573

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M git_cl.py View 3 chunks +11 lines, -4 lines 0 comments Download
M tests/git_cl_test.py View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Bons
4 years, 10 months ago (2016-02-02 19:41:43 UTC) #2
tandrii(chromium)
LGTM i'm not convinced making "-t|--title" specified a failure is the best way to convert ...
4 years, 10 months ago (2016-02-02 22:47:39 UTC) #3
Bons
People ignore warnings. If they use Gerrit they shouldn't use the option.
4 years, 10 months ago (2016-02-02 22:49:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1659633003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1659633003/1
4 years, 10 months ago (2016-02-02 22:49:30 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: depot_tools_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/depot_tools_presubmit/builds/405)
4 years, 10 months ago (2016-02-02 22:57:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1659633003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1659633003/20001
4 years, 10 months ago (2016-02-03 19:58:29 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 20:00:43 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298573

Powered by Google App Engine
This is Rietveld 408576698