Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issue 1659623003: X87: [builtins] Make Math.max and Math.min fast by default. (Closed)

Created:
4 years, 10 months ago by zhengxing.li
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [builtins] Make Math.max and Math.min fast by default. port cb9b801069c432e745f0651cf00d65ef88cd7f06 (r33582) original commit message: The previous versions of Math.max and Math.min made it difficult to optimize those (that's why we already have custom code in Crankshaft), and due to lack of ideas what to do about the variable number of arguments, we will probably need to stick in special code in TurboFan as well; so inlining those builtins is off the table, hence there's no real advantage in having them around as "not quite JS" with extra work necessary in the optimizing compilers to still make those builtins somewhat fast in cases where we cannot inline them (also there's a tricky deopt loop in Crankshaft related to Math.min and Math.max, but that will be dealt with later). So to sum up: Instead of trying to make Math.max and Math.min semi-fast in the optimizing compilers with weird work-arounds support %_Arguments %_ArgumentsLength, we do provide the optimal code as native builtins instead and call it a day (which gives a nice performance boost on some benchmarks). BUG= Committed: https://crrev.com/8944d36fd57aa398a911c7f1e567baf6ddb14b24 Cr-Commit-Position: refs/heads/master@{#33652}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -0 lines) Patch
M src/x87/builtins-x87.cc View 1 chunk +134 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 10 months ago (2016-02-02 02:04:43 UTC) #2
Weiliang
lgtm
4 years, 10 months ago (2016-02-02 02:12:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1659623003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1659623003/1
4 years, 10 months ago (2016-02-02 02:19:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-02 02:47:13 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 02:47:57 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8944d36fd57aa398a911c7f1e567baf6ddb14b24
Cr-Commit-Position: refs/heads/master@{#33652}

Powered by Google App Engine
This is Rietveld 408576698