DescriptionX87: [builtins] Make Math.max and Math.min fast by default.
port cb9b801069c432e745f0651cf00d65ef88cd7f06 (r33582)
original commit message:
The previous versions of Math.max and Math.min made it difficult to
optimize those (that's why we already have custom code in Crankshaft),
and due to lack of ideas what to do about the variable number of
arguments, we will probably need to stick in special code in TurboFan
as well; so inlining those builtins is off the table, hence there's no
real advantage in having them around as "not quite JS" with extra work
necessary in the optimizing compilers to still make those builtins
somewhat fast in cases where we cannot inline them (also there's a
tricky deopt loop in Crankshaft related to Math.min and Math.max, but
that will be dealt with later).
So to sum up: Instead of trying to make Math.max and Math.min semi-fast
in the optimizing compilers with weird work-arounds support %_Arguments
%_ArgumentsLength, we do provide the optimal code as native builtins
instead and call it a day (which gives a nice performance boost on some
benchmarks).
BUG=
Committed: https://crrev.com/8944d36fd57aa398a911c7f1e567baf6ddb14b24
Cr-Commit-Position: refs/heads/master@{#33652}
Patch Set 1 #
Messages
Total messages: 8 (3 generated)
|