Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 165953004: Add ApiCompatibilityUtils for setImageAlpha. (Closed)

Created:
6 years, 10 months ago by Ramya
Modified:
6 years, 10 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Add ApiCompatibilityUtils for setImageAlpha. ImageView.setImageAlpha is available only since JB. Use setAlpha preJB. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252054

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix typo #

Patch Set 3 : Upload failed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java View 1 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (0 generated)
Ramya
PTAL
6 years, 10 months ago (2014-02-14 19:51:31 UTC) #1
Yaron
lgtm
6 years, 10 months ago (2014-02-15 16:40:33 UTC) #2
cimamoglu (inactive)
lgtm https://codereview.chromium.org/165953004/diff/1/base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java File base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java (right): https://codereview.chromium.org/165953004/diff/1/base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java#newcode194 base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java:194: * @see android.view.View#postInvalidateOnAnimation()z Remove the typo "z" please
6 years, 10 months ago (2014-02-18 10:53:00 UTC) #3
Ramya
The CQ bit was checked by cramya@chromium.org
6 years, 10 months ago (2014-02-18 17:58:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cramya@chromium.org/165953004/1
6 years, 10 months ago (2014-02-18 17:59:05 UTC) #5
Ramya
The CQ bit was unchecked by cramya@chromium.org
6 years, 10 months ago (2014-02-18 17:59:08 UTC) #6
Ramya
https://codereview.chromium.org/165953004/diff/1/base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java File base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java (right): https://codereview.chromium.org/165953004/diff/1/base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java#newcode194 base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java:194: * @see android.view.View#postInvalidateOnAnimation()z On 2014/02/18 10:53:01, cimamoglu wrote: > ...
6 years, 10 months ago (2014-02-18 18:07:38 UTC) #7
Ramya
The CQ bit was checked by cramya@chromium.org
6 years, 10 months ago (2014-02-18 18:08:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cramya@chromium.org/165953004/200001
6 years, 10 months ago (2014-02-18 18:08:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cramya@chromium.org/165953004/200001
6 years, 10 months ago (2014-02-18 18:25:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cramya@chromium.org/165953004/200001
6 years, 10 months ago (2014-02-18 18:33:23 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-18 18:44:42 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 10 months ago (2014-02-18 18:44:42 UTC) #13
cimamoglu (inactive)
The CQ bit was checked by cimamoglu@chromium.org
6 years, 10 months ago (2014-02-19 09:57:09 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cramya@chromium.org/165953004/200001
6 years, 10 months ago (2014-02-19 09:57:18 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 09:57:39 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 10 months ago (2014-02-19 09:57:39 UTC) #17
cimamoglu (inactive)
Bot error seems irrelevant, put NOTRY and resubmit
6 years, 10 months ago (2014-02-19 12:16:05 UTC) #18
cimamoglu (inactive)
The CQ bit was checked by cimamoglu@chromium.org
6 years, 10 months ago (2014-02-19 12:16:12 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cramya@chromium.org/165953004/200001
6 years, 10 months ago (2014-02-19 12:16:25 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cramya@chromium.org/165953004/200001
6 years, 10 months ago (2014-02-19 14:58:36 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cramya@chromium.org/165953004/200001
6 years, 10 months ago (2014-02-19 15:28:39 UTC) #22
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 19:55:11 UTC) #23
Message was sent while issue was closed. 
Change committed as 252054

Powered by Google App Engine
This is Rietveld 408576698