Make a DirectiveElementBuilder class for use by BuildDirectiveElementsTask.

Make a DirectiveElementBuilder class for use by BuildDirectiveElementsTask.

This will make it easier to re-use code between
DirectiveElementBuilder and ElementBuilder, which will be necessary as
part of fixing dartbug.com/25285.

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/e9212699db76de2863ec299db314a6d326371bb6

[Paul Berry, 2016-02-02 03:56:00]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2016-02-02 14:58:16]

LGTM

https://codereview.chromium.org/1659523003/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/1659523003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:2658: class DirectiveElementBuilder
extends SimpleAstVisitor<Object> {
Consider moving this into it's own file, such as
lib/src/dart/element/builder.dart (into which we can later move ElementBuilder).

https://codereview.chromium.org/1659523003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:2860: if (combinator is
ShowCombinator) {
Would it make sense to use the visitor pattern here?

  for (Combinator combinator in directive.combinators) {
    combinators.add(combinator.accept(this));
  }

[Paul Berry, 2016-02-02 17:50:54]

https://codereview.chromium.org/1659523003/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/1659523003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:2658: class DirectiveElementBuilder
extends SimpleAstVisitor<Object> {
On 2016/02/02 14:58:16, Brian Wilkerson wrote:
> Consider moving this into it's own file, such as
> lib/src/dart/element/builder.dart (into which we can later move
ElementBuilder).

Done.

https://codereview.chromium.org/1659523003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:2860: if (combinator is
ShowCombinator) {
On 2016/02/02 14:58:16, Brian Wilkerson wrote:
> Would it make sense to use the visitor pattern here?
> 
>   for (Combinator combinator in directive.combinators) {
>     combinators.add(combinator.accept(this));
>   }

Done.

[Paul Berry, 2016-02-02 17:51:06]

Description was changed from

==========
Make a DirectiveElementBuilder class for use by BuildDirectiveElementsTask.

This will make it easier to re-use code between
DirectiveElementBuilder and ElementBuilder, which will be necessary as
part of fixing dartbug.com/25285.
==========

to

==========
Make a DirectiveElementBuilder class for use by BuildDirectiveElementsTask.

This will make it easier to re-use code between
DirectiveElementBuilder and ElementBuilder, which will be necessary as
part of fixing dartbug.com/25285.

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e9212699db76de2863ec299db314a6d326371bb6
==========

[Paul Berry, 2016-02-02 17:51:07]

Committed patchset #1 (id:1) manually as
e9212699db76de2863ec299db314a6d326371bb6 (presubmit successful).