Ignore GetHash results for lists that we don't support.

Ignore GetHash results for lists that we don't support.

BUG=5597
(http://crbug.com/5597)

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7710

[Erik does not do reviews, 2009-01-07 23:50:03]

http://codereview.chromium.org/16595/diff/1/2
File chrome/browser/safe_browsing/safe_browsing_database_bloom.cc (right):

http://codereview.chromium.org/16595/diff/1/2#newcode1428
Line 1428: entry.list_id = safe_browsing_util::GetListId(it->list_name);
do we need to handle an invalid list_id here?

[Paul Godavari, 2009-01-07 23:53:54]

On 2009/01/07 23:50:03, Erik Kay wrote:
> http://codereview.chromium.org/16595/diff/1/2
> File chrome/browser/safe_browsing/safe_browsing_database_bloom.cc (right):
> 
> http://codereview.chromium.org/16595/diff/1/2#newcode1428
> Line 1428: entry.list_id = safe_browsing_util::GetListId(it->list_name);
> do we need to handle an invalid list_id here?

The database won't see invalid list_ids since they are discarded at the parsing
level.

[Erik does not do reviews, 2009-01-08 00:42:35]

On 2009/01/07 23:53:54, Paul Godavari wrote:
> On 2009/01/07 23:50:03, Erik Kay wrote:
> > http://codereview.chromium.org/16595/diff/1/2
> > File chrome/browser/safe_browsing/safe_browsing_database_bloom.cc (right):
> > 
> > http://codereview.chromium.org/16595/diff/1/2#newcode1428
> > Line 1428: entry.list_id = safe_browsing_util::GetListId(it->list_name);
> > do we need to handle an invalid list_id here?
> 
> The database won't see invalid list_ids since they are discarded at the
parsing
> level.

OK. LGTM