Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1659483003: [tools] Flexible perf runner path. (Closed)

Created:
4 years, 10 months ago by Mircea Trofin
Modified:
4 years, 10 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[tools] Flexible perf runner path. Improved flexibility for the perf runner, by adding option to specify precisely shell binary. NOTRY=true Committed: https://crrev.com/0eb083155c83e2272eb2946fc4bfe0b3eb400481 Cr-Commit-Position: refs/heads/master@{#33649}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -6 lines) Patch
M tools/run_perf.py View 1 5 chunks +22 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Mircea Trofin
4 years, 10 months ago (2016-02-01 16:05:03 UTC) #3
Michael Achenbach
lgtm with comment: https://codereview.chromium.org/1659483003/diff/1/tools/run_perf.py File tools/run_perf.py (right): https://codereview.chromium.org/1659483003/diff/1/tools/run_perf.py#newcode858 tools/run_perf.py:858: print "specify either binary-override-path or shell-dir-no-patch" ...
4 years, 10 months ago (2016-02-01 20:02:24 UTC) #5
Michael Achenbach
Note, I copied the subject line to the first line of the CL desc.
4 years, 10 months ago (2016-02-01 20:02:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1659483003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1659483003/20001
4 years, 10 months ago (2016-02-01 20:25:51 UTC) #10
Mircea Trofin
https://codereview.chromium.org/1659483003/diff/1/tools/run_perf.py File tools/run_perf.py (right): https://codereview.chromium.org/1659483003/diff/1/tools/run_perf.py#newcode858 tools/run_perf.py:858: print "specify either binary-override-path or shell-dir-no-patch" On 2016/02/01 20:02:24, ...
4 years, 10 months ago (2016-02-01 20:25:53 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-01 20:27:26 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-01 20:27:58 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0eb083155c83e2272eb2946fc4bfe0b3eb400481
Cr-Commit-Position: refs/heads/master@{#33649}

Powered by Google App Engine
This is Rietveld 408576698