Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 1659463007: [turbofan] Remove untested no-deoptimization code path from JSGlobalObjectSpecialization. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove untested no-deoptimization code path from JSGlobalObjectSpecialization. We don't have proper test coverage for the no-deoptimization code paths in the JSGlobalObjectSpecialization reducer, and we will properly never have any use for that code, so it just adds complexity and code that likely breaks over time (as its untested). R=jarin@chromium.org Committed: https://crrev.com/9750708e2b72c4c7c026d931fd140ba48c76f0ce Cr-Commit-Position: refs/heads/master@{#33680}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -72 lines) Patch
M src/compiler/js-global-object-specialization.h View 4 chunks +1 line, -13 lines 0 comments Download
M src/compiler/js-global-object-specialization.cc View 6 chunks +36 lines, -53 lines 0 comments Download
M src/compiler/pipeline.cc View 2 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-02 12:09:22 UTC) #1
Benedikt Meurer
Hey Jaro, Untested code is likely broken code. Removing the potential dead code simplifies the ...
4 years, 10 months ago (2016-02-02 12:10:15 UTC) #2
Jarin
lgtm
4 years, 10 months ago (2016-02-02 12:37:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1659463007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1659463007/1
4 years, 10 months ago (2016-02-02 13:06:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-02 13:11:44 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 13:17:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9750708e2b72c4c7c026d931fd140ba48c76f0ce
Cr-Commit-Position: refs/heads/master@{#33680}

Powered by Google App Engine
This is Rietveld 408576698