Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Side by Side Diff: include/v8.h

Issue 1659433002: Don't schedule second pass callbacks if there are no callbacks (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/global-handles.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** \mainpage V8 API Reference Guide 5 /** \mainpage V8 API Reference Guide
6 * 6 *
7 * V8 is Google's open source JavaScript engine. 7 * V8 is Google's open source JavaScript engine.
8 * 8 *
9 * This set of documents provides reference material generated from the 9 * This set of documents provides reference material generated from the
10 * V8 header file, include/v8.h. 10 * V8 header file, include/v8.h.
(...skipping 414 matching lines...) Expand 10 before | Expand all | Expand 10 after
425 425
426 V8_INLINE V8_DEPRECATED("use indexed version", 426 V8_INLINE V8_DEPRECATED("use indexed version",
427 void* GetInternalField1() const) { 427 void* GetInternalField1() const) {
428 return internal_fields_[0]; 428 return internal_fields_[0];
429 } 429 }
430 V8_INLINE V8_DEPRECATED("use indexed version", 430 V8_INLINE V8_DEPRECATED("use indexed version",
431 void* GetInternalField2() const) { 431 void* GetInternalField2() const) {
432 return internal_fields_[1]; 432 return internal_fields_[1];
433 } 433 }
434 434
435 bool IsFirstPass() const { return callback_ != nullptr; } 435 V8_DEPRECATED("Not realiable once SetSecondPassCallback() was used.",
436 bool IsFirstPass() const) {
437 return callback_ != nullptr;
438 }
436 439
437 // When first called, the embedder MUST Reset() the Global which triggered the 440 // When first called, the embedder MUST Reset() the Global which triggered the
438 // callback. The Global itself is unusable for anything else. No v8 other api 441 // callback. The Global itself is unusable for anything else. No v8 other api
439 // calls may be called in the first callback. Should additional work be 442 // calls may be called in the first callback. Should additional work be
440 // required, the embedder must set a second pass callback, which will be 443 // required, the embedder must set a second pass callback, which will be
441 // called after all the initial callbacks are processed. 444 // called after all the initial callbacks are processed.
442 // Calling SetSecondPassCallback on the second pass will immediately crash. 445 // Calling SetSecondPassCallback on the second pass will immediately crash.
443 void SetSecondPassCallback(Callback callback) const { *callback_ = callback; } 446 void SetSecondPassCallback(Callback callback) const { *callback_ = callback; }
444 447
445 private: 448 private:
(...skipping 8077 matching lines...) Expand 10 before | Expand all | Expand 10 after
8523 */ 8526 */
8524 8527
8525 8528
8526 } // namespace v8 8529 } // namespace v8
8527 8530
8528 8531
8529 #undef TYPE_CHECK 8532 #undef TYPE_CHECK
8530 8533
8531 8534
8532 #endif // INCLUDE_V8_H_ 8535 #endif // INCLUDE_V8_H_
OLDNEW
« no previous file with comments | « no previous file | src/global-handles.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698