Issue 165943003: Remove observer when switching from import overlay to create profile overlay.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 165943003: Remove observer when switching from import overlay to create profile overlay. (Closed)

Created:
6 years, 10 months ago by Adrian Kuegel

Modified:
6 years, 10 months ago

Reviewers:
Pam (message me for reviews)

CC:
chromium-reviews, dbeam+watch-options_chromium.org, tfarina, pam+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove observer when switching from import overlay to create profile overlay. Currently the observer is only removed if the overlay is closed. Also remove it in case we switch to the create profile overlay. This fixes an assertion. BUG=344813 TEST=Switch between import overlay and create profile overlay. TBR=pam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252071

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/resources/options/managed_user_import.js	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akuegel@chromium.org/165943003/1

6 years, 10 months ago (2014-02-19 13:51:15 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akuegel@chromium.org/165943003/1

6 years, 10 months ago (2014-02-19 15:02:50 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akuegel@chromium.org/165943003/1

6 years, 10 months ago (2014-02-19 15:30:48 UTC) #5

Message was sent while issue was closed.

Change committed as 252071

Expand Messages | Collapse Messages