Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: tools/testing/dart/fletch_warnings_suite.dart

Issue 1659163007: Rename fletch -> dartino (Closed) Base URL: https://github.com/dartino/sdk.git@master
Patch Set: address comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/fletch_test_suite.dart ('k') | tools/testing/dart/runtime_configuration.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/fletch_warnings_suite.dart
diff --git a/tools/testing/dart/fletch_warnings_suite.dart b/tools/testing/dart/fletch_warnings_suite.dart
deleted file mode 100644
index e4050fb42ff7b7c29d2e8394a79acffef5e5c04d..0000000000000000000000000000000000000000
--- a/tools/testing/dart/fletch_warnings_suite.dart
+++ /dev/null
@@ -1,138 +0,0 @@
-// Copyright (c) 2015, the Dartino project authors. Please see the AUTHORS file
-// for details. All rights reserved. Use of this source code is governed by a
-// BSD-style license that can be found in the LICENSE.md file.
-
-library test.fletch_warnings_suite;
-
-import 'dart:io' as io;
-
-import 'dart:convert' show
- UTF8;
-
-import 'test_suite.dart' show
- TestSuite,
- TestUtils;
-
-import 'test_runner.dart' show
- Command,
- CommandBuilder,
- CompilationCommandOutputImpl,
- TestCase;
-
-import 'runtime_configuration.dart' show
- RuntimeConfiguration;
-
-import 'status_file_parser.dart' show
- Expectation,
- TestExpectations;
-
-import 'compiler_configuration.dart' show
- CommandArtifact;
-
-const Map<String, String> URIS_TO_ANALYZE = const <String, String>{
- "hub_main": "package:fletchc/src/hub/hub_main.dart",
- "fletch_test_suite": "tests/fletch_tests/fletch_test_suite.dart",
- "test_dart": "tools/test.dart",
-};
-
-class FletchWarningsRuntimeConfiguration extends RuntimeConfiguration {
- final String system;
- final String dartBinary;
-
- FletchWarningsRuntimeConfiguration(Map configuration)
- : system = configuration['system'],
- dartBinary = '${TestUtils.buildDir(configuration)}'
- '${io.Platform.pathSeparator}dart',
- super.subclass();
-
- List<Command> computeRuntimeCommands(
- TestSuite suite,
- CommandBuilder commandBuilder,
- CommandArtifact artifact,
- String script,
- List<String> arguments,
- Map<String, String> environmentOverrides) {
- return <Command>[
- commandBuilder.getAnalysisCommand(
- 'dart2js-analyze-only',
- dartBinary,
- <String>[
- '--packages=.packages', // For the VM.
- './third_party/dart/pkg/compiler/lib/src/dart2js.dart',
- '--packages=.packages', // For dart2js.
- '--library-root=third_party/dart/sdk/',
- '--analyze-only',
- '--show-package-warnings',
- '--categories=Server',
- '--allow-native-extensions']..addAll(arguments),
- null,
- flavor: 'dart2js')];
- }
-}
-
-class FletchWarningsSuite extends TestSuite {
- FletchWarningsSuite(Map configuration, testSuiteDir)
- : super(configuration, "warnings");
-
- void forEachTest(
- void onTest(TestCase testCase),
- Map testCache,
- [void onDone()]) {
- this.doTest = onTest;
- if (configuration['runtime'] != 'fletch_warnings') {
- onDone();
- return;
- }
-
- RuntimeConfiguration runtimeConfiguration =
- new RuntimeConfiguration(configuration);
-
- // There are no status files for this. Please fix warnings.
- TestExpectations expectations = new TestExpectations();
-
- URIS_TO_ANALYZE.forEach((String testName, String uri) {
- List<Command> commands = runtimeConfiguration.computeRuntimeCommands(
- this,
- CommandBuilder.instance,
- null,
- uri,
- <String>[uri],
- null);
- var testCase = new TestCase(
- '$suiteName/$testName',
- commands,
- configuration, expectations.expectations(testName));
- enqueueNewTestCase(testCase);
- });
-
- onDone();
- }
-}
-
-/// Pattern that matches warnings (from dart2js) that contain a comment saying
-/// "NO_LINT".
-final RegExp noLintFilter =
- new RegExp(r"[^\n]*\n[^\n]*\n[^\n]* // NO_LINT\n *\^+\n");
-
-class FletchWarningsOutputCommand extends CompilationCommandOutputImpl {
- FletchWarningsOutputCommand(
- Command command, int exitCode, bool timedOut,
- List<int> stdout, List<int> stderr,
- Duration time, bool compilationSkipped)
- : super(
- command, exitCode, timedOut, stdout, stderr, time,
- compilationSkipped);
-
- Expectation result(TestCase testCase) {
- Expectation result = super.result(testCase);
- if (result != Expectation.PASS) return result;
-
- var filteredStdout =
- UTF8.decode(stdout, allowMalformed: true).replaceAll(noLintFilter, "");
- if (filteredStdout.isNotEmpty) {
- return Expectation.STATIC_WARNING;
- }
-
- return Expectation.PASS;
- }
-}
« no previous file with comments | « tools/testing/dart/fletch_test_suite.dart ('k') | tools/testing/dart/runtime_configuration.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698