scripts/slave/recipe_modules/ios/api.py - Issue 1659163003: WebRTC: Add iOS bots running tests with the simulator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/ios/api.py

Issue 1659163003: WebRTC: Add iOS bots running tests with the simulator (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Updated more expectations Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipe_modules/ios/api.py

diff --git a/scripts/slave/recipe_modules/ios/api.py b/scripts/slave/recipe_modules/ios/api.py

index 8c0ba7bd91cfd8c565a874489fba6b0acc17204a..ffbc307a48058830198dbf1d57c684cd1690745a 100644

--- a/scripts/slave/recipe_modules/ios/api.py

+++ b/scripts/slave/recipe_modules/ios/api.py

@@ -149,6 +149,7 @@ class iOSApi(recipe_api.RecipeApi):

self.__config.setdefault('env', {})

self.__config.setdefault('mb_type', None)

self.__config.setdefault('gn_args', [])

+ self.__config.setdefault('use_analyze', True)

# Elements of the "tests" list are dicts. There are two types of elements,

# determined by the presence of one of these mutually exclusive keys:

@@ -303,7 +304,9 @@ class iOSApi(recipe_api.RecipeApi):

name='generate_build_files' + suffix,

build_dir='//out/' + build_sub_path)

- if (self.compiler == 'ninja' and

+ use_analyze = self.__config['use_analyze']

+ if (use_analyze and

+ self.compiler == 'ninja' and

self.m.tryserver.is_tryserver and

'without patch' not in suffix):

affected_files = self.m.tryserver.get_files_affected_by_patch()

« no previous file with comments | « masters/master.client.webrtc.fyi/slaves.cfg ('k') | scripts/slave/recipe_modules/ios/example.expected/basic.json » ('j') | no next file with comments »