Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1659163003: WebRTC: Add iOS bots running tests with the simulator (Closed)

Created:
4 years, 10 months ago by kjellander_chromium
Modified:
4 years, 10 months ago
Reviewers:
smut
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/remotes/origin/master
Project:
build
Visibility:
Public.

Description

WebRTC: Add iOS bots running tests with the simulator Add recipes and two experimental bots in client.webrtc.fyi to try this out. This CL adds support for a 'use_analyze' variable to be specified in the JSON bot configs in case analyze is not be used. This depends on buildbot configurations that are added in https://codereview.webrtc.org/1660053002/ BUG=chromium:498746 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298548

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated more expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+696 lines, -222 lines) Patch
M masters/master.client.webrtc.fyi/master_mac_cfg.py View 2 chunks +14 lines, -1 line 0 comments Download
M masters/master.client.webrtc.fyi/slaves.cfg View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/ios/api.py View 2 chunks +4 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/ios/example.expected/basic.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/ios/example.expected/clobber.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ios/try.expected/basic.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ios/try.expected/gn.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ios/try.expected/parent.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ios/try.expected/without_patch_failure.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ios/try.expected/without_patch_success.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ios/unified_builder_tester.expected/basic.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ios/unified_builder_tester.expected/goma.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ios/unified_builder_tester.expected/infrastructure_failure.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ios/unified_builder_tester.expected/multiple_failures.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ios/unified_builder_tester.expected/no_tests.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ios/unified_builder_tester.expected/test_failure.json View 1 1 chunk +1 line, -1 line 0 comments Download
A + scripts/slave/recipes/webrtc/ios.py View 6 chunks +30 lines, -73 lines 0 comments Download
A scripts/slave/recipes/webrtc/ios.expected/basic.json View 1 1 chunk +260 lines, -0 lines 0 comments Download
A + scripts/slave/recipes/webrtc/ios.expected/infrastructure_failure.json View 1 3 chunks +7 lines, -67 lines 0 comments Download
A scripts/slave/recipes/webrtc/ios.expected/no_tests.json View 1 1 chunk +179 lines, -0 lines 0 comments Download
A + scripts/slave/recipes/webrtc/ios.expected/test_failure.json View 1 3 chunks +7 lines, -67 lines 0 comments Download
A scripts/slave/recipes/webrtc/ios.expected/trybot.json View 1 1 chunk +180 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
kjellander_chromium
https://codereview.chromium.org/1659163003/diff/1/scripts/slave/recipes/webrtc/ios.expected/basic.json File scripts/slave/recipes/webrtc/ios.expected/basic.json (right): https://codereview.chromium.org/1659163003/diff/1/scripts/slave/recipes/webrtc/ios.expected/basic.json#newcode63 scripts/slave/recipes/webrtc/ios.expected/basic.json:63: "[SLAVE_BUILD]/src/webrtc/build/ios/chromium.fake/ios.json", This proves it is possible to specify our ...
4 years, 10 months ago (2016-02-02 22:31:38 UTC) #3
smut
Should work. Worth trying. Lgtm. https://codereview.chromium.org/1659163003/diff/1/scripts/slave/recipes/webrtc/ios.expected/basic.json File scripts/slave/recipes/webrtc/ios.expected/basic.json (right): https://codereview.chromium.org/1659163003/diff/1/scripts/slave/recipes/webrtc/ios.expected/basic.json#newcode63 scripts/slave/recipes/webrtc/ios.expected/basic.json:63: "[SLAVE_BUILD]/src/webrtc/build/ios/chromium.fake/ios.json", On 2016/02/02 22:31:38, ...
4 years, 10 months ago (2016-02-02 22:38:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1659163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1659163003/1
4 years, 10 months ago (2016-02-03 08:01:47 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/1636)
4 years, 10 months ago (2016-02-03 08:08:10 UTC) #8
kjellander_chromium
On 2016/02/03 08:08:10, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 10 months ago (2016-02-03 08:53:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1659163003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1659163003/20001
4 years, 10 months ago (2016-02-03 08:53:55 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 08:57:17 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298548

Powered by Google App Engine
This is Rietveld 408576698