Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1659033002: Revert of Remove --no-sandbox flag from command line for telemetry (Closed)

Created:
4 years, 10 months ago by ssid
Modified:
4 years, 10 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@sandbox
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove --no-sandbox flag from command line for telemetry (patchset #4 id:60001 of https://codereview.chromium.org/1584583003/ ) Reason for revert: MemoryInfra benchmarks are failing after this CL. crbug.com/583101 Original issue's description: > Remove --no-sandbox flag from command line for telemetry > > Now that the browser is able to dump for child processes the > --no-sandbox flag is not required for getting memory statistics. So, > this is removed form the telemetry benchmarks. > > BUG=461788 > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:win_perf_bisect > > Committed: https://crrev.com/2bf18cfdfa1b8b0bd829edea2d90277e7e5b0b71 > Cr-Commit-Position: refs/heads/master@{#372667} TBR=primiano@chromium.org,nednguyen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=461788 Committed: https://crrev.com/203ca2a0729aa404fc724583a360377a3793cae4 Cr-Commit-Position: refs/heads/master@{#372927}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M base/trace_event/memory_dump_manager.cc View 1 chunk +3 lines, -1 line 0 comments Download
M tools/perf/benchmarks/memory_infra.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/oortonline.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/v8.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ssid
Created Revert of Remove --no-sandbox flag from command line for telemetry
4 years, 10 months ago (2016-02-02 11:47:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1659033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1659033002/1
4 years, 10 months ago (2016-02-02 11:48:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-02 11:49:33 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/203ca2a0729aa404fc724583a360377a3793cae4 Cr-Commit-Position: refs/heads/master@{#372927}
4 years, 10 months ago (2016-02-02 11:55:25 UTC) #6
Primiano Tucci (use gerrit)
lgtm
4 years, 10 months ago (2016-02-02 11:56:57 UTC) #7
ssid
4 years, 10 months ago (2016-02-04 11:48:02 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1663053005/ by ssid@chromium.org.

The reason for reverting is: All the bots that failed were running Precise have
been moved to Trusty now. crbug.com/583408..

Powered by Google App Engine
This is Rietveld 408576698