Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 1659023002: [interpreter] Unify meaning of register count operands. (Closed)

Created:
4 years, 10 months ago by oth
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Unify meaning of register count operands. Unifies the meaning of kRegCount8 and kRegCount16 across bytecodes. Call and CallJSRuntime had a slightly different use of the register count operand. From this change forth, register count operands are always based off of the previous register operand. BUG=v8:4280, v8:4675 LOG=N Committed: https://crrev.com/3c64400f194938c3fb66e18a42df7709157b379a Cr-Commit-Position: refs/heads/master@{#33707}

Patch Set 1 #

Patch Set 2 : Remove the TODO addressed by this CL. #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -88 lines) Patch
M src/compiler/bytecode-graph-builder.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/interpreter-assembler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/interpreter-assembler.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-array-builder.h View 1 2 2 chunks +11 lines, -11 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 2 2 chunks +23 lines, -18 lines 0 comments Download
M src/interpreter/bytecode-array-iterator.cc View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 2 2 chunks +9 lines, -11 lines 0 comments Download
M src/interpreter/interpreter.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 1 2 22 chunks +32 lines, -33 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
oth
PTAL, thanks.
4 years, 10 months ago (2016-02-02 10:43:52 UTC) #2
oth
mstarzinger@chromium.org: Please review changes in compiler, thanks.
4 years, 10 months ago (2016-02-02 16:10:06 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1659023002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1659023002/20001
4 years, 10 months ago (2016-02-02 16:10:43 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-02 16:50:22 UTC) #8
rmcilroy
lgtm, thanks.
4 years, 10 months ago (2016-02-03 11:45:57 UTC) #9
Michael Starzinger
LGTM on "compiler".
4 years, 10 months ago (2016-02-03 13:53:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1659023002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1659023002/40001
4 years, 10 months ago (2016-02-03 14:57:40 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-03 15:22:21 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 15:22:57 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3c64400f194938c3fb66e18a42df7709157b379a
Cr-Commit-Position: refs/heads/master@{#33707}

Powered by Google App Engine
This is Rietveld 408576698