third_party/WebKit/LayoutTests/fast/frames/open-then-unload.html - Issue 1659013003: Don't reset LoadEventProgress if frame unload has already started.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/frames/open-then-unload.html

Issue 1659013003: Don't reset LoadEventProgress if frame unload has already started. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: test Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script src="../../resources/js-test.js"></script>

	5 <script>

	6 jsTestIsAsync = true;

	7

	8 function runTest() {

	9 description('Test that document.open() doesn\'t allow frames to be attached du ring frame detach.');

	10 window[0].document.open();
	dcheng 2016/02/03 03:13:29 At this point, LoadEventProgress gets reset to Loa At this point, LoadEventProgress gets reset to LoadEventNotRun without my patch.
	11 window[0].document.appendChild(document.createElement('iframe'));
	dcheng 2016/02/03 03:13:29 Right now, our tree looks like this: [Main frame] Right now, our tree looks like this: [Main frame] \| [Child A] (m_loadEventProgress == LoadEventNotRun) Since this child frame won't run unload events, we nest another frame under Child A: [Main frame] \| [Child A] (m_loadEventProgress == LoadEventNotRun) \| [Child B] (m_loadEventProgress == LoadEventCompleted)
	12 window[0][0].addEventListener('unload', function() {

	13 window[0].document.documentElement.appendChild(document.createElement('ifram e'));
	dcheng 2016/02/03 03:13:29 Since Child B's load event progress is normal, we Since Child B's load event progress is normal, we can use an unload handler to try to attach a frame to [Child A] as it is navigating.
	14 shouldBe('1', 'window[0].length');
	dcheng 2016/02/03 03:13:29 If the iframe load is blocked, then window[0].leng If the iframe load is blocked, then window[0].length should remain at 1.
	15 shouldBeUndefined('window[0][1]');

	16 finishJSTest();

	17 });

	18 window[0].location = 'data:text/plain,Hello world!';

	19 }

	20 </script>

	21 </head>

	22 <body onload="runTest()">

	23 <iframe></iframe>

	24 </body>

	25 </html>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/frames/open-then-unload-expected.txt » ('j') | third_party/WebKit/Source/core/dom/Document.cpp » ('J')