ipc/mojo/ipc_channel_mojo_unittest.cc - Issue 1659003003: IPC::Message -> base::Pickle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/mojo/ipc_channel_mojo_unittest.cc

Issue 1659003003: IPC::Message -> base::Pickle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: export base::Pickle::Attachment Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ipc/mojo/ipc_channel_mojo_unittest.cc

diff --git a/ipc/mojo/ipc_channel_mojo_unittest.cc b/ipc/mojo/ipc_channel_mojo_unittest.cc

index b4f4154c67ce2b9509578f05816e13814abde69c..e27ec5df61ffc16994c918eead2ca5654b76901a 100644

--- a/ipc/mojo/ipc_channel_mojo_unittest.cc

+++ b/ipc/mojo/ipc_channel_mojo_unittest.cc

@@ -378,9 +378,10 @@ class HandleSendingHelper {

static void ReadReceivedFile(const IPC::Message& message,

base::PickleIterator* iter) {

base::ScopedFD fd;

- scoped_refptr<IPC::MessageAttachment> attachment;

+ scoped_refptr<base::Pickle::Attachment> attachment;

EXPECT_TRUE(message.ReadAttachment(iter, &attachment));

- base::File file(attachment->TakePlatformFile());

+ base::File file(static_cast<IPC::MessageAttachment*>(attachment.get())

+ ->TakePlatformFile());

std::string content(GetSendingFileContent().size(), ' ');

file.Read(0, &content[0], content.size());

EXPECT_EQ(content, GetSendingFileContent());