Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: ppapi/proxy/raw_var_data.cc

Issue 1659003003: IPC::Message -> base::Pickle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: one more mac fix Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/proxy/raw_var_data.h ('k') | ppapi/proxy/raw_var_data_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/proxy/raw_var_data.cc
diff --git a/ppapi/proxy/raw_var_data.cc b/ppapi/proxy/raw_var_data.cc
index 6e4e0577d5f41fb929adc8673d5c51e3a8b81761..302695183fe9f8df8224ca9c4e274fd2437abb95 100644
--- a/ppapi/proxy/raw_var_data.cc
+++ b/ppapi/proxy/raw_var_data.cc
@@ -173,7 +173,7 @@ PP_Var RawVarDataGraph::CreatePPVar(PP_Instance instance) {
return graph[0];
}
-void RawVarDataGraph::Write(IPC::Message* m,
+void RawVarDataGraph::Write(base::Pickle* m,
const HandleWriter& handle_writer) {
// Write the size, followed by each node in the graph.
m->WriteUInt32(static_cast<uint32_t>(data_.size()));
@@ -184,7 +184,7 @@ void RawVarDataGraph::Write(IPC::Message* m,
}
// static
-scoped_ptr<RawVarDataGraph> RawVarDataGraph::Read(const IPC::Message* m,
+scoped_ptr<RawVarDataGraph> RawVarDataGraph::Read(const base::Pickle* m,
base::PickleIterator* iter) {
scoped_ptr<RawVarDataGraph> result(new RawVarDataGraph);
uint32_t size = 0;
@@ -283,9 +283,8 @@ void BasicRawVarData::PopulatePPVar(const PP_Var& var,
const std::vector<PP_Var>& graph) {
}
-void BasicRawVarData::Write(
- IPC::Message* m,
- const HandleWriter& handle_writer) {
+void BasicRawVarData::Write(base::Pickle* m,
+ const HandleWriter& handle_writer) {
switch (var_.type) {
case PP_VARTYPE_UNDEFINED:
case PP_VARTYPE_NULL:
@@ -311,7 +310,7 @@ void BasicRawVarData::Write(
}
bool BasicRawVarData::Read(PP_VarType type,
- const IPC::Message* m,
+ const base::Pickle* m,
base::PickleIterator* iter) {
PP_Var result;
result.type = type;
@@ -377,13 +376,13 @@ void StringRawVarData::PopulatePPVar(const PP_Var& var,
const std::vector<PP_Var>& graph) {
}
-void StringRawVarData::Write(IPC::Message* m,
+void StringRawVarData::Write(base::Pickle* m,
const HandleWriter& handle_writer) {
m->WriteString(data_);
}
bool StringRawVarData::Read(PP_VarType type,
- const IPC::Message* m,
+ const base::Pickle* m,
base::PickleIterator* iter) {
if (!iter->ReadString(&data_))
return false;
@@ -482,9 +481,8 @@ void ArrayBufferRawVarData::PopulatePPVar(const PP_Var& var,
const std::vector<PP_Var>& graph) {
}
-void ArrayBufferRawVarData::Write(
- IPC::Message* m,
- const HandleWriter& handle_writer) {
+void ArrayBufferRawVarData::Write(base::Pickle* m,
+ const HandleWriter& handle_writer) {
m->WriteInt(type_);
switch (type_) {
case ARRAY_BUFFER_SHMEM_HOST:
@@ -500,7 +498,7 @@ void ArrayBufferRawVarData::Write(
}
bool ArrayBufferRawVarData::Read(PP_VarType type,
- const IPC::Message* m,
+ const base::Pickle* m,
base::PickleIterator* iter) {
int shmem_type;
if (!iter->ReadInt(&shmem_type))
@@ -572,7 +570,7 @@ void ArrayRawVarData::PopulatePPVar(const PP_Var& var,
array_var->elements().push_back(ScopedPPVar(graph[children_[i]]));
}
-void ArrayRawVarData::Write(IPC::Message* m,
+void ArrayRawVarData::Write(base::Pickle* m,
const HandleWriter& handle_writer) {
m->WriteUInt32(static_cast<uint32_t>(children_.size()));
for (size_t i = 0; i < children_.size(); ++i)
@@ -580,7 +578,7 @@ void ArrayRawVarData::Write(IPC::Message* m,
}
bool ArrayRawVarData::Read(PP_VarType type,
- const IPC::Message* m,
+ const base::Pickle* m,
base::PickleIterator* iter) {
uint32_t size;
if (!iter->ReadUInt32(&size))
@@ -635,9 +633,8 @@ void DictionaryRawVarData::PopulatePPVar(const PP_Var& var,
}
}
-void DictionaryRawVarData::Write(
- IPC::Message* m,
- const HandleWriter& handle_writer) {
+void DictionaryRawVarData::Write(base::Pickle* m,
+ const HandleWriter& handle_writer) {
m->WriteUInt32(static_cast<uint32_t>(children_.size()));
for (size_t i = 0; i < children_.size(); ++i) {
m->WriteString(children_[i].first);
@@ -646,7 +643,7 @@ void DictionaryRawVarData::Write(
}
bool DictionaryRawVarData::Read(PP_VarType type,
- const IPC::Message* m,
+ const base::Pickle* m,
base::PickleIterator* iter) {
uint32_t size;
if (!iter->ReadUInt32(&size))
@@ -712,7 +709,7 @@ void ResourceRawVarData::PopulatePPVar(const PP_Var& var,
const std::vector<PP_Var>& graph) {
}
-void ResourceRawVarData::Write(IPC::Message* m,
+void ResourceRawVarData::Write(base::Pickle* m,
const HandleWriter& handle_writer) {
m->WriteInt(static_cast<int>(pp_resource_));
m->WriteInt(pending_renderer_host_id_);
@@ -723,7 +720,7 @@ void ResourceRawVarData::Write(IPC::Message* m,
}
bool ResourceRawVarData::Read(PP_VarType type,
- const IPC::Message* m,
+ const base::Pickle* m,
base::PickleIterator* iter) {
int value;
if (!iter->ReadInt(&value))
« no previous file with comments | « ppapi/proxy/raw_var_data.h ('k') | ppapi/proxy/raw_var_data_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698